Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Add missing curly brace. Typo fix for a module import. #240

Merged
merged 13 commits into from
Apr 11, 2016
Merged

Add missing curly brace. Typo fix for a module import. #240

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6188f85
Set obj as any to avoid comiplation errors.
gburdeti Apr 10, 2016
9e370da
Merge branch 'master' of https://github.com/Microsoft/TypeScript-Hand…
gburdeti Apr 10, 2016
e513455
Add the missing curly brace.
gburdeti Apr 10, 2016
d90ee5b
Use a type assertion to any in order to avoid a compilation error.
gburdeti Apr 10, 2016
c2fcb24
Call the RegExp constructor to avoid a compilation error.
gburdeti Apr 10, 2016
7b95612
Revert change.
gburdeti Apr 10, 2016
56e3dce
Revert change.
gburdeti Apr 10, 2016
80e81b8
Change obj assignment as suggested in pull request comments.
gburdeti Apr 10, 2016
cb0060f
Revert to old version. Compile error happens only with *noImplicitAny…
gburdeti Apr 10, 2016
3d08381
Merge branch 'master' of https://github.com/gburdeti/TypeScript-Handbook
gburdeti Apr 10, 2016
b267c76
Change the variable name to avoid duplicate conflict.
gburdeti Apr 10, 2016
a66068c
Typo fix for a module import using ```import =```.
gburdeti Apr 10, 2016
e01a8bf
Update Advanced Types.md as per received comment.
gburdeti Apr 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pages/Iterators and Generators.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ for (let i in list) {

for (let i of list) {
console.log(i); // "4", "5", "6"
}
```

Another distinction is that `for..in` operates on any object; it serves as a way to inspect properties on this object.
Expand Down
2 changes: 1 addition & 1 deletion pages/Symbols.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Just like strings, symbols can be used as keys for object properties.
```ts
let sym = Symbol();

let obj = {};
let obj: any = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change it to:

let obj = {
   [sym]: "value"
};

console.log(obj[sym]); // "value"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same idea actually, good call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is that we never explained computer properties 😄


obj[sym] = "value";
console.log(obj[sym]); // "value"
Expand Down