Add nodeParent property to HTML, Document and DocumentFragment #66
Conversation
Add parentNode property to Element, Document and DocumentFragment. spec; [ParentNode](https://developer.mozilla.org/en-US/docs/Web/API/ParentNode)
delete extra space.
Add childElementCount property.
|
In the Living standard, parentNode property of the Node interface return a Node. However, it not implemented because of abstract interface. In order to eliminate the error, should I change the parentNode of the return type? |
baselines/dom.generated.d.ts
Outdated
| new(): HTMLPictureElement; | ||
| } | ||
|
|
||
| interface parentNode { |
There was a problem hiding this comment.
use Camel Case. so ParentNode
|
|
inputfiles/addedTypes.json
Outdated
| ] | ||
| }, | ||
| { | ||
| "kind": "property", |
There was a problem hiding this comment.
i do not think this should be a property.
There was a problem hiding this comment.
Is this interface, too?
There was a problem hiding this comment.
it should be added to the extends list. i do not know how to do that though :) @zhengbli what is the right way to do this?
|
@zhengbli any ideas? |
|
The support for adding |
Merge remote-tracking branch 'tsjsupstream/master'
|
I missed operation. I close this PR and redo. |
4 participants
Add parentNode property to Element, Document and DocumentFragment.
spec: ParentNode
original issue: ParentNode interface isn't implemented in lib.d.ts #4400