Emit only instance members from global polluters

[Tomislav Jovanovic (zombie)]

I believe this is correct, static members from global polluters shouldn't show up as globals.

[github-actions]

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

[Tomislav Jovanovic (zombie)]

I tried looking in inputfiles/, but I don't really understand where this difference from baselines is coming from.

    -/** @deprecated */
    -declare const name: void;
    +declare var name: string;

[Kagami Sascha Rosylight (saschanaz)]

It's special cased here:

TypeScript-DOM-lib-generator/src/build/emitter.ts

Lines 803 to 810 in be2cad9

	if (
	p.name === "name" &&
	i.name === "Window" &&
	emitScope === EmitScope.All
	) {
	printer.printLine("/** @deprecated */");
	printer.printLine("declare const name: void;");
	} else {

Changing that should fix the failure.

(But Gecko has static member in global interfaces? 🤔🤔🤔 / Edit: Oh, isInstance, yeah.)

[Tomislav Jovanovic (zombie)]

It's special cased here:

Thanks, I had a feeling I was looking in the wrong places.

[Kagami Sascha Rosylight (saschanaz)]

LGTM, thanks!

[github-actions]

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!