Emit only instance members from global polluters#1910
Merged
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Contributor
Author
|
I tried looking in |
saschanaz
suggested changes
Feb 12, 2025
Collaborator
There was a problem hiding this comment.
It's special cased here:
TypeScript-DOM-lib-generator/src/build/emitter.ts
Lines 803 to 810 in be2cad9
Changing that should fix the failure.
(But Gecko has static member in global interfaces? 🤔🤔🤔 / Edit: Oh, isInstance, yeah.)
Contributor
Author
Thanks, I had a feeling I was looking in the wrong places. |
Collaborator
|
LGTM, thanks! |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is correct, static members from global polluters shouldn't show up as globals.