Enhance translation tests and restructure player schema#2684
Open
robgruen wants to merge 13 commits into
Open
Conversation
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request.. let's take the "Regenerate docs" name change. |
Contributor
Merged main into the branch — no conflicts. The |
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request, just take the incoming. |
…peAgent into dev/robgruen/flakey
# Conflicts: # ts/packages/dispatcher/dispatcher/README.AUTOGEN.md
Contributor
Merged main into the branch and took the incoming version for all conflicts (the only conflict was in the auto-generated |
…actions
The playerSchema.agr renamed two actions in a prior commit but the variant
fixture grammars and benchmark JSONL were left with the old names:
- `resume` → `resumePlayback`
- `playTrack` (flat params) → `playMusic` (target: { kind, ... } params)
This caused `generateAllDeltas()` to produce 466 spurious deltas (vs the 25
committed rows) because every resume and play-by-artist corpus entry created
a delta between HEAD and each variant.
Changes:
- v1-v9 variant .agr files: Resume rules updated to `resumePlayback`;
PlaySpecificTrack rules updated to `playMusic` with target-nested params
- player.regression-benchmark.jsonl: 3 v1-lost-transport rows updated
(actionA.actionName `resume` → `resumePlayback`)
- player.utterances.jsonl: corpus expectedAction fields updated to new names
(resume → resumePlayback, playTrack → playMusic with new parameter structure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema parser and type resolution improvements:
resolveUnionMemberWithFieldutility and updatedcheckParamSpecsandgetPropertyPartTypeto support property-path navigation into discriminated union members, allowing parameters liketarget.trackNameto be validated and resolved correctly. [1] [2] [3] [4] [5]Refactoring and unification of music actions:
playTrack,playAlbum,playArtist,playGenre) with unifiedplayMusicandfindMusicactions using a discriminated uniontargetparameter, and updated all related logic, including parameter validation and completion. [1] [2] [3] [4] [5] F024fdadL12R12, [6]Schema and grammar updates:
playerSchema.jsonto use the new parameter paths (e.g.,target.trackName) forplayMusicandfindMusic, and removed obsolete parameter specs and emoji completions for old actions. (F024fdadL12R12, ts/packages/agents/player/src/agent/playerSchema.jsonL64-R63)playerSchema.agrto generate the new unified actions and fixed the resume action mapping. [1] [2]Codebase cleanup:
Workflow metadata: