Skip to content

Comments

Add Neon implementation of replace_copy#6090

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
hazzlim:replace-neon-pr
Feb 24, 2026
Merged

Add Neon implementation of replace_copy#6090
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
hazzlim:replace-neon-pr

Conversation

@hazzlim
Copy link
Contributor

@hazzlim hazzlim commented Feb 18, 2026

This PR adds a Neon implementation of replace_copy. Note: given #4433 we cannot implement in-place replace using Neon.

⏱️ Benchmark results:

  MSVC Speedup Clang Speedup
rcstd::uint8_t 16.786 0.977
rcstd::uint16_t 8.333 1
rcstd::uint32_t 4.304 1.018
rcstd::uint64_t 2.558 1.19

@hazzlim hazzlim requested a review from a team as a code owner February 18, 2026 12:15
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Feb 18, 2026
@StephanTLavavej StephanTLavavej added performance Must go faster ARM64 Related to the ARM64 architecture ARM64EC I can't believe it's not x64! labels Feb 18, 2026
@StephanTLavavej StephanTLavavej self-assigned this Feb 18, 2026
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Feb 18, 2026
@StephanTLavavej StephanTLavavej removed their assignment Feb 18, 2026
@StephanTLavavej
Copy link
Member

I wish all PRs were like your crystalline perfection! 💎 🦾 😻

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Feb 23, 2026
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej StephanTLavavej merged commit d9a326b into microsoft:main Feb 24, 2026
45 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Feb 24, 2026
@StephanTLavavej
Copy link
Member

🦾 🧑‍🔧 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARM64EC I can't believe it's not x64! ARM64 Related to the ARM64 architecture performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants