<optional>: Add Address Sanitizer annotations
#6010
+165
−7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Copyright (c) Microsoft Corporation. | ||
|
Member
There was a problem hiding this comment. ultra subjective nit - can we name this folder |
||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| RUNALL_INCLUDE ..\usual_17_matrix.lst | ||
|
Member
There was a problem hiding this comment. Following in the precedent set by Any reason not to reuse the same test matrix as in the linked example? |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #include <cassert> | ||
| #include <optional> | ||
|
|
||
| #ifdef __SANITIZE_ADDRESS__ | ||
| extern "C" int __cdecl __asan_address_is_poisoned(void const volatile* addr); | ||
| #define ASAN_VERIFY_POISONED(addr) assert(__asan_address_is_poisoned((addr)) != 0) | ||
| #define ASAN_VERIFY_UNPOISONED(addr) assert(__asan_address_is_poisoned((addr)) == 0) | ||
| #else | ||
| #define ASAN_VERIFY_POISONED(addr) ((void) (addr)) | ||
| #define ASAN_VERIFY_UNPOISONED(addr) ((void) (addr)) | ||
| #endif | ||
|
|
||
| struct Payload { | ||
| long long x; | ||
| long long y; | ||
| long long z; | ||
| long long w; | ||
| }; | ||
|
|
||
| void test_poison_on_empty_access() { | ||
| [[maybe_unused]] std::optional<Payload> opt; | ||
| ASAN_VERIFY_POISONED(reinterpret_cast<Payload*>(&opt)); | ||
| } | ||
|
|
||
| void test_emplace_unpoisoning() { | ||
| std::optional<Payload> opt; | ||
| opt.emplace(); | ||
| ASAN_VERIFY_UNPOISONED(reinterpret_cast<Payload*>(&opt)); | ||
| } | ||
|
|
||
| void test_assignment_unpoisoning() { | ||
| std::optional<Payload> opt = std::nullopt; | ||
| opt = Payload{}; | ||
| ASAN_VERIFY_UNPOISONED(reinterpret_cast<Payload*>(&opt)); | ||
| } | ||
|
|
||
| void test_repoison_after_reset() { | ||
| std::optional<Payload> opt = Payload{}; | ||
| ASAN_VERIFY_UNPOISONED(reinterpret_cast<Payload*>(&opt)); | ||
| opt.reset(); | ||
| ASAN_VERIFY_POISONED(reinterpret_cast<Payload*>(&opt)); | ||
| } | ||
|
|
||
| constexpr bool test_constexpr() { | ||
| #if _HAS_CXX20 | ||
| bool res = true; | ||
| std::optional<Payload> opt = std::nullopt; | ||
| opt = Payload{}; | ||
| opt.reset(); | ||
| opt = Payload{86, 0, 0, 0}; | ||
| res = opt->x == 86; | ||
| opt.emplace(42, 0, 0, 0); | ||
| res = res && (opt->x == 42); | ||
| return res; | ||
| #else | ||
| std::optional<Payload> opt{Payload{86, 0, 0, 0}}; | ||
| return opt->x == 86; | ||
| #endif | ||
| } | ||
|
|
||
| int main() { | ||
| test_poison_on_empty_access(); | ||
| test_emplace_unpoisoning(); | ||
| test_assignment_unpoisoning(); | ||
| test_repoison_after_reset(); | ||
StephanTLavavej marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| static_assert(test_constexpr(), "constexpr test failed"); | ||
|
|
||
| return 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable isn't used. Is it really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a check for this variable inside the
if(!_STD _Is_constant_evaluated())block.