Skip to content

Implement LWG-4398: enable_nonlocking_formatter_optimization should be disabled for container adaptors #5883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement LWG-4398: enable_nonlocking_formatter_optimization should be disabled for container adaptors #5883

wants to merge 2 commits into from
+25 −0

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Nov 19, 2025 •
edited
Loading

Closes #4924.
Closes #5860.

Partial template specializations added in 96bcef5 are redundant (this code already does the job), but IMO they improve the readability of the code.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner November 19, 2025 17:08
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Nov 19, 2025
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue format C++20/23 format labels Nov 19, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Nov 20, 2025
@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Nov 21, 2025

This should also resolve #4924.

@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Nov 25, 2025
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Nov 25, 2025

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

No one assigned

Labels

format C++20/23 format LWG Library Working Group issue

Projects

STL Code Reviews
Status: Merging

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LWG-4398 enable_nonlocking_formatter_optimization should be disabled for container adaptors <queue>, <stack>: P3235R3 not implemented

3 participants

@JMazurkiewicz @frederick-vs-ja @StephanTLavavej