FIX Prevent blocking file I/O on async paths - #2452
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
FIX Prevent blocking file I/O on async paths#2452Roman Lutz (romanlutz) wants to merge 1 commit into
Roman Lutz (romanlutz) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Async backend, CLI, and dataset-loading paths were performing synchronous file and filesystem operations, which could block the event loop and serialize concurrent work.
This change moves straightforward asynchronous file reads and writes to
aiofiles, and runs blocking JSON parsing, synchronous dataset loading, and path-heavy filesystem checks throughasyncio.to_thread. Existing exception behavior, ordering, caching semantics, and public APIs are preserved.Tests and Documentation
Added deterministic unit coverage for the new event-loop-safe boundaries in the version route, initializer upload flow, FigStep loader, and VLGuard loader.
Validated with the focused 86-test suite, Ruff format/check, changed-file
ty, the async-suffix check, commit hooks, andgit diff --check.Documentation and JupyText: N/A.