Consolidate chat attachment copying - #2448
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment on lines
+558
to
+570
| const inputBox = inputBoxRef.current | ||
| if (!inputBox) { return } | ||
|
|
||
| if (message.content) { | ||
| inputBox.setText(message.content) | ||
| } | ||
| if (!message.attachments) { return } | ||
|
|
||
| for (const attachment of message.attachments) { | ||
| if (attachment.type !== 'file') { | ||
| inputBox.addAttachment(attachment) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| const inputBox = inputBoxRef.current | |
| if (!inputBox) { return } | |
| if (message.content) { | |
| inputBox.setText(message.content) | |
| } | |
| if (!message.attachments) { return } | |
| for (const attachment of message.attachments) { | |
| if (attachment.type !== 'file') { | |
| inputBox.addAttachment(attachment) | |
| } | |
| } | |
| const inputBox = inputBoxRef.current | |
| if (!inputBox) return | |
| if (message.content) { | |
| inputBox.setText(message.content) | |
| } | |
| for(const attachment of message.attachments ?? []) { | |
| if (attachment.type !== 'file') { | |
| inputBox.addAttachment(attachment) | |
| } | |
| } |
hannahwestra25
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChatWindowduplicated the same message-to-input attachment loop in its direct copy and copy-to-new-conversation actions, making the two paths easy to change inconsistently.This extracts a shared, component-local copy operation for the identical success behavior. It preserves non-file attachment ordering and metadata, keeps the delayed new-conversation update unchanged, and leaves the distinct text-only creation-failure fallback separate.
Focused tests cover both shared call paths, file filtering, attachment order and metadata preservation, and the failure fallback.
Validation:
ChatWindowJest testsgit diff --check