[BREAKING] FEAT: Add fixed egress deployment for CoPyRIT - #2438
Open
Bashir Partovi (bashirpartovi) wants to merge 3 commits into
Open
[BREAKING] FEAT: Add fixed egress deployment for CoPyRIT#2438Bashir Partovi (bashirpartovi) wants to merge 3 commits into
Bashir Partovi (bashirpartovi) wants to merge 3 commits into
Conversation
added 3 commits
August 19, 2026 23:46
Deploy the GUI on a VNet-integrated public Container Apps environment with static NAT egress and optional Azure Front Door. Harden the Azure DevOps workflow around immutable image digests, fail-closed what-if validation, and preservation of the reserved public IP. Update isolated-instance lifecycle guidance and add focused infrastructure tests.
Apply the repository-pinned Ruff formatter, resolve typing-only imports and long fixture lines, and normalize file endings for the new infrastructure Python files.
Add the trailing newlines required by the cross-platform end-of-file pre-commit hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR establishes one supported CoPyRIT Azure topology: a public workload-profiles Azure Container Apps environment on a dedicated delegated subnet, with a Standard NAT Gateway and static public IP for fixed outbound egress. Azure Front Door Premium is optional and uses the public ACA hostname as its HTTPS origin; the direct ACA URL remains available as a documented diagnostic and rollback path.
The Azure DevOps deployment workflow now:
CanNotDeletelock to the static egress public IP and verifies its resource ID and address after deployment;The isolated-instance lifecycle scripts now validate Azure CLI JSON boundaries, configure SQL and Storage firewalls with the static egress IP, use ownership tags, and require explicit acknowledgement before teardown releases an allow-listed IP.
Breaking change: the existing
enablePrivateEndpointparameter and its Azure Container Apps environment Private Endpoint and private DNS resources are removed, along with the previous Private Endpoint subnet parameters. Existing deployments that use this path must migrate to a parallel VNet-integrated public ACA environment with fixed NAT egress because an ACA environment network type cannot be converted in place. Pipeline callers must adopt the deployment parameters documented ininfra/README.md.Tests and Documentation
python -m unittest discover -s tests/unit/infra -p 'test_*.py' -qΓÇö 23 tests pass.infra/main.bicep,infra/modules/aca_nat_network.bicep, andinfra/modules/aca_front_door.bicepwith Azure CLI/Bicep.py_compilefor both lifecycle scripts and the what-if validator.bash -nfor the container startup and deployment scripts.git diff --check.infra/README.mdandinfra/DEPLOY_NEW_INSTANCE.mdwith the supported topology, ingress/egress behavior, migration boundary, pipeline contract, lifecycle safeguards, and teardown requirements.