Skip to content

FIX give each multiselect checkbox its own accessible name #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejas_0007 (tejas0077) wants to merge 3 commits into
base: main
Choose a base branch
from
+14 −1
Open

FIX give each multiselect checkbox its own accessible name #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e441c72
fix(frontend): give each multiselect checkbox its own accessible name
Aug 19, 2026
02ed9c4
Merge branch 'main' into fix/multiselect-checkbox-accessible-names
romanlutz Aug 20, 2026
4b16354
Merge branch 'main' into fix/multiselect-checkbox-accessible-names
hannahwestra25 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions frontend/src/components/Initializers/AdditionalInitializers.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,15 @@ export const useAdditionalInitializersStyles = makeStyles({
flexDirection: 'column',
gap: tokens.spacingVerticalXXS,
},
srOnly: {
position: 'absolute',
width: '1px',
height: '1px',
padding: '0',
margin: '-1px',
overflow: 'hidden',
clip: 'rect(0,0,0,0)',
whiteSpace: 'nowrap',
borderWidth: '0',
},
})
4 changes: 3 additions & 1 deletion frontend/src/components/Initializers/InitializerParametersDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,13 @@ function ParameterField({ parameter, value, disabled, onChange }: ParameterField
const selected = Array.isArray(value) ? value : []
return (
<Field label={label} hint={parameter.description ?? undefined}>
<div className={styles.checkboxGroup} role="group" aria-label={parameter.name}>
<div className={styles.checkboxGroup} role="group" aria-labelledby={`param-${parameter.name}-group-label`}>
<span id={`param-${parameter.name}-group-label`} className={styles.srOnly}>{label}</span>
{(parameter.choices ?? []).map((choice) => (
<Checkbox
key={choice}
id={`param-${parameter.name}-${choice}`}
aria-label={choice}

@hannahwestra25 hannahwestra25 Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fluent’s Field still injects aria-labelledby, which takes precedence over aria-label, so these may still be announced as “tags.” We could explicitly connect each checkbox to its own label:

const choiceLabelId = `param-${parameter.name}-${choice}-label`

<Checkbox
  label={{ children: choice, id: choiceLabelId }}
  aria-labelledby={choiceLabelId}
/>

label={choice}
checked={selected.includes(choice)}
disabled={disabled}
Expand Down
Loading