-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add a React sample for Power Pages BYOC #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add a React sample for Power Pages BYOC #712
Conversation
- ✏️ Clarified steps for creating a new web role and table. - 📜 Added instructions for creating table permissions. - 🔧 Fixed formatting for web API enablement instructions. -Priyanshu
- 📝 Corrected wording in the instructions for running the app on Power Pages. -Priyanshu
📝 Clarified instructions for installing Power Platform Tools VS Code extension to enhance future uploads. -Priyanshu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added comments and some changes I'd like you to make.
Major change is to provide a managed solution that contains definitions for any dependent tables or other solution components that the sample depends on. Instructions that the consumers of the sample manually create these results in too many errors.
Providing a managed solution allows for improving reliability and makes it easy for the customer to remove the components by deleting the managed solution.
Ideally, there should be some way for this site to indicate a dependency on a given solution.
portals/bring-your-own-code-samples/react-sample/src/pages/SalesLeads.tsx
Outdated
Show resolved
Hide resolved
portals/bring-your-own-code-samples/react-sample/src/pages/SalesLeads.tsx
Outdated
Show resolved
Hide resolved
``` | ||
react-sample/ | ||
├── public/ | ||
│ └── car.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier we unblocked js files. svg files are blocked by default too. Does this image get uploaded?
This request returns results that include svg
.
GET [Organization Uri]/api/data/v9.2/organizations?$select=blockedattachments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not seen svg getting blocked in any of the environments I have tested. Assuming the same for customers, otherwise they will have to unblock this as well.
portals/bring-your-own-code-samples/react-sample/src/components/AuthButton.tsx
Outdated
Show resolved
Hide resolved
- ✨ Added ThemeToggle component to the structure - 🗂️ Organized components and pages into separate directories - 📄 Updated file paths in the documentation for clarity -Priyanshu
Introduce a sample application for managing car sales using React and Vite to run on Power Pages. The sample also includes steps on how to run this application on Power Pages after necessary changes.