Skip to content

Refactor BlobManager tracking, support getPendingBlobs and abort for payload pending blobs #25642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChumpChief merged 29 commits into from
Oct 9, 2025
Merged

Refactor BlobManager tracking, support getPendingBlobs and abort for payload pending blobs #25642

Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
1a3eb1a
Port and update prototype
ChumpChief Oct 1, 2025
84f4177
Restore a couple things
ChumpChief Oct 1, 2025
169590b
Restore storageId identity entry
ChumpChief Oct 2, 2025
f801c84
Ensure we try to hit storage for readBlob error test case
ChumpChief Oct 2, 2025
f322563
Drop extra props from uploadBlob abort error
ChumpChief Oct 2, 2025
f178d89
Remove stale comments and unhelpful satisfies
ChumpChief Oct 2, 2025
47b4ebd
Support TTL, make upload/attach flow linear regardless of failure ent…
ChumpChief Oct 3, 2025
e01d120
Support abort
ChumpChief Oct 6, 2025
349ef35
Better promise/error handling
ChumpChief Oct 6, 2025
e2af35a
Remove extra abort check
ChumpChief Oct 6, 2025
dc36218
Support calling with uploaded blob
ChumpChief Oct 6, 2025
c9115f2
Unify upload/attach flow
ChumpChief Oct 6, 2025
37bf9c3
Reorganize using subroutines
ChumpChief Oct 7, 2025
f60f11c
Rearrange abort checking, add comments
ChumpChief Oct 7, 2025
1ba4174
Pending handle cleanup, initial getPendingBlobs, add TODOs
ChumpChief Oct 7, 2025
23757aa
Tiny rename
ChumpChief Oct 7, 2025
2aa7674
Support attach ops arriving at surprising times
ChumpChief Oct 7, 2025
1374bfa
Fix some TODOs
ChumpChief Oct 7, 2025
1b63b94
Add sharePendingBlobs
ChumpChief Oct 7, 2025
1c7eae1
Get first test working
ChumpChief Oct 7, 2025
a226ff2
Bunch of comments, fix up abort flows
ChumpChief Oct 8, 2025
b099f82
More comments
ChumpChief Oct 8, 2025
1dc3a02
Enable abort tests for payload pending
ChumpChief Oct 8, 2025
fe56e90
Remove stale comment
ChumpChief Oct 8, 2025
57c94fe
Remove attachAndGetPendingBlobs()
ChumpChief Oct 8, 2025
b9bc987
Add comment about treating uploaded and attaching blobs the same
ChumpChief Oct 8, 2025
7379161
Add incoming pending blobs to pendingBlobsWithAttachedHandles
ChumpChief Oct 9, 2025
37b9c9b
More docs, remoteId -> storageId
ChumpChief Oct 9, 2025
9e25282
Merge remote-tracking branch 'upstream/main' into BlobManagerInternals
ChumpChief Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading