Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Oct 6, 2025

importConcise and exportConcise were previously available via TreeAlpha.
They may now be accessed via TreeBeta.

Also promotes related type definitions.

AB#50044

@Josmithr Josmithr requested a review from CraigMacomber October 6, 2025 22:12
@Josmithr Josmithr requested review from a team as code owners October 6, 2025 22:12
@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 22:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request promotes the importConcise and exportConcise APIs from TreeAlpha to TreeBeta, making them available at the beta stability level. The PR also promotes related type definitions including ConciseTree, UnsafeUnknownSchema, TreeEncodingOptions, and KeyEncodingOptions to beta.

Key changes:

  • Move importConcise and exportConcise methods from TreeAlpha to TreeBeta interface
  • Update all test files and examples to use TreeBeta instead of TreeAlpha for these methods
  • Promote related types from alpha to beta in API documentation and type definitions

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/dds/tree/src/simple-tree/api/treeBeta.ts Adds importConcise and exportConcise method implementations to TreeBeta interface
packages/dds/tree/src/shared-tree/treeAlpha.ts Removes importConcise and exportConcise methods from TreeAlpha interface
packages/dds/tree/src/simple-tree/unsafeUnknownSchema.ts Updates UnsafeUnknownSchema type annotations from @Alpha to @beta
packages/dds/tree/src/simple-tree/api/customTree.ts Updates TreeEncodingOptions and KeyEncodingOptions annotations from @Alpha to @beta
packages/dds/tree/src/simple-tree/api/conciseTree.ts Updates ConciseTree type annotation from @Alpha to @beta
Multiple test files Updates imports and method calls to use TreeBeta instead of TreeAlpha for concise operations
API report files Reflects the promotion of types and methods from alpha to beta

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree area: examples Changes that focus on our examples changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Oct 6, 2025
@Josmithr Josmithr requested review from a team and CraigMacomber October 7, 2025 13:57
@github-actions github-actions bot added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Oct 7, 2025
): Unhydrated<TreeFieldFromImplicitField<TSchema>>;
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of new code below here. Some PR comments noting which of this are moved and which are new would be helpful for review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this is new - it was all copied from TreeAlpha. That said, I noticed that I inadvertently duplicated borrowCursorFromTreeNodeOrValue rather than move it here. I have no deduplicated it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "new" code would be what is now in TreeAlpha to maintain APIs for import/export there.

@CraigMacomber
Copy link
Contributor

"must " in the PR description is out of date

Josmithr and others added 2 commits October 7, 2025 13:27
@Josmithr Josmithr requested a review from CraigMacomber October 7, 2025 20:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

🔗 Found some broken links! 💔

Run a link check locally to find them. See
https://github.com/microsoft/FluidFramework/wiki/Checking-for-broken-links-in-the-documentation for more information.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

 ELIFECYCLE  Command failed with exit code 1.

@Josmithr Josmithr enabled auto-merge (squash) October 8, 2025 14:14
@Josmithr Josmithr merged commit b5d4602 into microsoft:main Oct 8, 2025
38 checks passed
@Josmithr Josmithr deleted the tree/stablize-import-export branch October 8, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: dds: tree area: dds Issues related to distributed data structures area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants