-
Notifications
You must be signed in to change notification settings - Fork 557
feat(tree): Promote importConcise and exportConcise to beta #25629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): Promote importConcise and exportConcise to beta #25629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request promotes the importConcise and exportConcise APIs from TreeAlpha to TreeBeta, making them available at the beta stability level. The PR also promotes related type definitions including ConciseTree, UnsafeUnknownSchema, TreeEncodingOptions, and KeyEncodingOptions to beta.
Key changes:
- Move
importConciseandexportConcisemethods from TreeAlpha to TreeBeta interface - Update all test files and examples to use TreeBeta instead of TreeAlpha for these methods
- Promote related types from alpha to beta in API documentation and type definitions
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/dds/tree/src/simple-tree/api/treeBeta.ts | Adds importConcise and exportConcise method implementations to TreeBeta interface |
| packages/dds/tree/src/shared-tree/treeAlpha.ts | Removes importConcise and exportConcise methods from TreeAlpha interface |
| packages/dds/tree/src/simple-tree/unsafeUnknownSchema.ts | Updates UnsafeUnknownSchema type annotations from @Alpha to @beta |
| packages/dds/tree/src/simple-tree/api/customTree.ts | Updates TreeEncodingOptions and KeyEncodingOptions annotations from @Alpha to @beta |
| packages/dds/tree/src/simple-tree/api/conciseTree.ts | Updates ConciseTree type annotation from @Alpha to @beta |
| Multiple test files | Updates imports and method calls to use TreeBeta instead of TreeAlpha for concise operations |
| API report files | Reflects the promotion of types and methods from alpha to beta |
…ants of import/export on `TreeAlpha`
| ): Unhydrated<TreeFieldFromImplicitField<TSchema>>; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of new code below here. Some PR comments noting which of this are moved and which are new would be helpful for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this is new - it was all copied from TreeAlpha. That said, I noticed that I inadvertently duplicated borrowCursorFromTreeNodeOrValue rather than move it here. I have no deduplicated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "new" code would be what is now in TreeAlpha to maintain APIs for import/export there.
|
"must " in the PR description is out of date |
Co-authored-by: Craig Macomber (Microsoft) <[email protected]>
…ithr/FluidFramework into tree/stablize-import-export
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
importConciseandexportConcisewere previously available via TreeAlpha.They may now be accessed via TreeBeta.
Also promotes related type definitions.
AB#50044