Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webpack-dev-server from 4.0.0 to 4.6.0 #10293

Merged
merged 2 commits into from
May 19, 2022
Merged

Update webpack-dev-server from 4.0.0 to 4.6.0 #10293

merged 2 commits into from
May 19, 2022

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented May 16, 2022 •
edited
Loading

#9568

Description

Update webpack-dev-server from 4.0.0 to 4.6.0

In webpack-dev-server 4.7 types were added and it no longer builds with our version of @types/node, thus this only updates to 4.6.

PR Checklist

Use the check-list below to ensure your branch is ready for PR. If the item is not applicable, leave it blank.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran the lint checks which produced no new errors nor warnings for my changes.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.

Does this introduce a breaking change?

  • Yes
  • No

If this introduces a breaking change, please describe the impact and migration path for existing applications below.

Testing

In addition to the automated build and CI, I confirmed a few apps worked correctly, including collaborative-text-area, monaco, and property-inspector.

Any relevant logs or outputs

  • Use this section to provide either screenshots or output of logs as code snippets

Other information or known dependencies

  • Any other information or known dependencies that is important to this PR.
  • TODO that are to be done after this PR.

@github-actions github-actions bot added area: dds: propertydds area: examples Changes that focus on our examples dependencies Pull requests that update a dependency file base: main PRs targeted against main branch area: build Build related issues area: dds Issues related to distributed data structures area: dds: sharedstring area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc breaking change This PR or issue would introduce a breaking change documentation Improvements or additions to documentation public api change Changes to a public API labels May 16, 2022
@CraigMacomber CraigMacomber force-pushed the update-webpack-dev-server branch from 3a63ec9 to e1fec2a Compare May 19, 2022 22:16
@github-actions github-actions bot removed area: odsp-driver public api change Changes to a public API documentation Improvements or additions to documentation area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: definitions breaking change This PR or issue would introduce a breaking change area: tests Tests to add, test infrastructure improvements, etc area: build Build related issues area: loader Loader related issues labels May 19, 2022
@github-actions github-actions bot removed area: driver Driver related issues area: runtime Runtime related issues area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: server Server related issues (routerlicious) area: dds: sharedstring labels May 19, 2022
@CraigMacomber CraigMacomber marked this pull request as ready for review May 19, 2022 23:10
@CraigMacomber CraigMacomber requested review from msfluid-bot and a team as code owners May 19, 2022 23:10
tylerbutler
tylerbutler approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥅

@CraigMacomber CraigMacomber merged commit 5385ca1 into microsoft:main May 19, 2022
@curtisman curtisman mentioned this pull request Jun 18, 2022
Closed
@CraigMacomber CraigMacomber deleted the update-webpack-dev-server branch May 17, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees
No one assigned
Labels
area: dds: propertydds area: examples Changes that focus on our examples base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CraigMacomber @tylerbutler