This repository was archived by the owner on Apr 28, 2018. It is now read-only.
Adding -Id and -Name params to Get-Container #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| foreach (var id in Id) | ||
| { | ||
| WriteObject(await ContainerOperations.GetContainersById(id, DkrClient)); |
There was a problem hiding this comment.
What happens in the pipeline if we dont get back a value?
There was a problem hiding this comment.
I think this is safe; the underlying function returns an array that happens to be empty, as we discussed offline.
As part of this change, updated to the most recent generated Docker.DotNet api (see dotnet/Docker.DotNet#81) to enable filtering on listing containers. Also included update to the tab-completion logic in ContainerArgumentCompleter to make it more efficient. Also updated callers of GetContainerById to more specifically filter based on requested items. This resolves #75.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this change, updated to the most recent generated Docker.DotNet api (see dotnet/Docker.DotNet#81) to enable filtering on listing containers.
Also included update to the tab-completion logic in ContainerArgumentCompleter to make it more efficient.
Also updated callers of GetContainerById to more specifically filter based on requested items.
This resolves #75.