Use WARP from nuget by default #7427
Conversation
- remove special cases for warp - move the generic sounding "nuget.cmake" closer to where it is used, and rename to DownloadWarp.cmake - rearrange clang/test/CMakeLists.txt to make logic clearer about what is / isn't executed when using a multi-config generator
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
There was a problem hiding this comment.
I was slightly surprised you didn't place this file under cmake/modules, not that I know much about cmake conventions. I was also thinking we should get the AgilitySDK from nuget as well, so I wonder if defining a general function for installing nugets would be even better.
There was a problem hiding this comment.
Ok, I now see that the original contained the general FetchNuGetPackage function, plus warp-specific code. Why wouldn't we want a general function defined under cmake/modules?
There was a problem hiding this comment.
Mainly because I don't want to spend time trying to design and build a generic function for installing nuget packages when we only have a need for this one. If we find a need for another, then we might be able to figure out what the common requirements between the two are and we can make an appropriate decision then.
Previously using WARP from nuget was something that had to be opted in to. This change makes it the default behvior.
This allows some simplifications. The nuget package is installed at configure time. If the user wants to override the nuget installation behavior then they can pass in extra parameters, rather than having an alternative mechanism for describing which package to use.
The actual DLL to load is specified through a TAEF parameter and specifies the full path to the DLL.