Skip to content

Report unhandled errors in sync context to WinUI 3 #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: staging/2.3
Choose a base branch
from
Open

Report unhandled errors in sync context to WinUI 3 #2005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ca4243
Report unhandled errors in sync context to XAML
dongle-the-gadget Jun 3, 2025
54e48a6
Revert unneeded reporting in UWP
dongle-the-gadget Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Projections/WinAppSDK/Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,18 @@ public override void Post(SendOrPostCallback d, object state)
if (d == null)
throw new ArgumentNullException(nameof(d));

m_dispatcherQueue.TryEnqueue(() => d(state));
m_dispatcherQueue.TryEnqueue(() =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manodasanW should we consider just sharing the synchronization context from UWP XAML with WinUI 3 instead (just changing the IID of course)? That one already has this fix, plus it's also more efficient. Thoughts?

{
try
{
d(state);
}
catch (Exception ex)
{
ExceptionHelpers.ReportUnhandledError(ex);
throw;
}
});
}

public override void Send(SendOrPostCallback d, object state)
Expand Down