Skip to content

[Master]-]Withholding Tax Entries are not generated at payment because the Withholding Tax. Prod. Posting Group field gets not transferred to the payment line.#9323

Closed
neeleshsinghal wants to merge 7 commits into
mainfrom
bugs/Bug-639524-Withhold-Tax-Prod-Posting-Group-field-gets-transferred1
Closed

[Master]-]Withholding Tax Entries are not generated at payment because the Withholding Tax. Prod. Posting Group field gets not transferred to the payment line.#9323
neeleshsinghal wants to merge 7 commits into
mainfrom
bugs/Bug-639524-Withhold-Tax-Prod-Posting-Group-field-gets-transferred1

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

@neeleshsinghal neeleshsinghal requested a review from a team July 11, 2026 00:42
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 11, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 11, 2026
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 6 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Agent 1 0 1 1 0

Totals: 0 knowledge-backed · 1 agent findings.

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

…ldingTaxJnlSubscriber.Codeunit.al

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DocumentNo: Code[20];
StartingDocumentNo: Code[20];
begin
// [SCENARIO 639524] Withholding Tax Prod. Post. Group travels from the applied Invoice to the Payment line via the Create Payment action and Withholding Tax Entries are generated when the Payment is posted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟡\ Medium\ Severity\ —\ Agent} \quad \color{gray}{\texttt{\small Iteration\ 6}}$

The new test's [SCENARIO] comment states that 'Withholding Tax Entries are generated when the Payment is posted', but the test never posts the generated payment Gen.

Journal Line and never asserts anything against the Withholding Tax Entry table. Only the propagation of 'Wthldg. Tax Prod. Post. Group' onto the unposted payment line is verified.

Recommendation:

  • either extend the test to post the payment line and assert the resulting Withholding Tax Entry, or narrow the [SCENARIO] comment to match the actual assertions so the test's documented intent matches its real coverage.

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant