[Shopify] Add Unlisted product status#9321
Open
onbuyuka wants to merge 1 commit into
Open
Conversation
Shopify added the UNLISTED value to its GraphQL ProductStatus enum (visible from API version 2025-10 onward). The connector uses API version 2026-07, so importing an unlisted product previously fell back to Active, misrepresenting the product. Add the Unlisted value to the "Shpfy Product Status" enum so the status is mapped correctly on both import and export. Fixes AB#642074 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bbea116d-8175-459f-b8f5-f628665a5cc7
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Shopify added the
UNLISTEDvalue to its GraphQLProductStatusenum (visible from API version 2025-10 onward). The Shopify Connector talks to API version 2026-07, but the"Shpfy Product Status"enum (30130) only knew aboutActive,Archived, andDraft. As a result,ShpfyProductAPI.ConvertToProductStatuscould not map theUNLISTEDstring and silently fell back toActive, misrepresenting unlisted products on import.This adds the
Unlistedvalue to the enum. Because the value name matches the cleaned Shopify string, both directions now work with no further code changes: import mapsUNLISTED→Unlisted, and export uppercases the enum name back toUNLISTED.Linked work
Fixes AB#642074
How I validated this
What I tested and the outcome
UpdateShopifyProductFields) with a product payload carrying"status":"UNLISTED"; the resultingShpfy Productrecord was mapped toUnlistedinstead of the previousActivefallback.Risk & compatibility
Low. The change only adds a new enum value; existing
Active/Archived/Drafthandling is unchanged, and the enum isExtensible = false. Products that were incorrectly stored asActivebecause they areUNLISTEDin Shopify will be corrected toUnlistedon the next sync.