Skip to content

Migrate obsoleted "Object Name" field to "Name" and fix silent truncation #9312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SBalslev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Migrate obsoleted "Object Name" field to "Name" and fix silent truncation #9312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Apps/CZ/CoreLocalizationPack/app/Src/Codeunits/VATStmtXMLExportHelperCZL.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ codeunit 11787 "VAT Stmt XML Export Helper CZL"
Report::"Export VAT Ctrl. Dialog CZL":
FieldsDeclaration := StrSubstNo(ExportVATCtrlDialogPKFieldsTxt, VATControlReportNoTok);
end;
exit(StrSubstNo(ReportParametersTxt, ReportID, AllObjWithCaption."Object Name", FieldsDeclaration));
exit(StrSubstNo(ReportParametersTxt, ReportID, AllObjWithCaption.Name, FieldsDeclaration));
end;

procedure UpdateParamsVATStatementName(var XMLTxt: Text; VATStatementName: Record "VAT Statement Name")
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/IN/INGST/app/GSTBase/src/Codeunit/MigrateEcomMerchantData.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ codeunit 18025 "Migrate Ecom Merchant Data"

if TableID <> 0 then begin
AllObj.Get(AllObj."Object Type"::Table, TableID);
TableName := AllObj."Object Name";
TableName := AllObj.Name;
end;

MigrationDialog.Update(1, TableName);
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/EDocumentConnectors/Avalara/App/src/Extensions/TransformationRule.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ tableextension 6374 "Transformation Rule" extends "Transformation Rule"
}
field(6371; "Lookup Table Name"; Text[30])

@pri-kise pri-kise Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that the PR is now only draft, but I was just wanted to confirm:
will those field length be updated to the new length (This is how I understood the PR description)?

Do we need obsoletion process like it was done for the home page field in the Base App?
That would require 3 Releases and the CalcForumula couldn't be changed right now.

Or will the platform ignore overflow of Lookups?

{
CalcFormula = lookup(AllObjWithCaption."Object Name" where("Object Type" = const(Table), "Object ID" = field("Lookup Table ID")));
CalcFormula = lookup(AllObjWithCaption.Name where("Object Type" = const(Table), "Object ID" = field("Lookup Table ID")));
Caption = 'Lookup Table Name';
Editable = false;
FieldClass = FlowField;
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/HybridBaseDeployment/app/src/codeunits/CloudMigReplicateDataMgt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ codeunit 40021 "Cloud Mig. Replicate Data Mgt."

TableNameFilter := '';
repeat
TableNameFilter += '|' + AllObj."Object Name";
TableNameFilter += '|' + AllObj.Name;
until AllObj.Next() = 0;

TableNameFilter := CopyStr(TableNameFilter, 2, StrLen(TableNameFilter) - 1);
Expand Down
4 changes: 2 additions & 2 deletions src/Apps/W1/HybridBaseDeployment/app/src/codeunits/HybridReplicationStatistics.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ codeunit 40029 "Hybrid Replication Statistics"
exit(false);

AllObjects.GetRecord(AllObj);
TableNameFilter := AllObj."Object Name";
TableNameFilter := AllObj.Name;

if AllObj."Object Type" = AllObj."Object Type"::Table then
if TableMetadata.Get(AllObj."Object ID") then
Expand All @@ -228,7 +228,7 @@ codeunit 40029 "Hybrid Replication Statistics"
HybridReplicationDetail.SetCurrentKey("End Time");
if not HybridReplicationDetail.FindLast() then begin
if GuiAllowed() then
Message(NoDataWasReplicatedFortableLbl, AllObj."Object Name");
Message(NoDataWasReplicatedFortableLbl, AllObj.Name);
exit(false);
end;

Expand Down
4 changes: 2 additions & 2 deletions src/Apps/W1/HybridBaseDeployment/app/src/pages/AddMigrationTableMappings.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ page 40010 "Add Migration Table Mappings"
ToolTip = 'Specifies the ID of the destination table.';
}

field(ObjectName; Rec."Object Name")
field(ObjectName; Rec.Name)
{
ApplicationArea = All;
Caption = 'Name';
Expand Down Expand Up @@ -234,7 +234,7 @@ page 40010 "Add Migration Table Mappings"
MigrationTableMapping."Data Per Company" := DataPerCompany;

if MigrationTableMapping."Target Table Type" = TargetMigrationTableType::Table then
MigrationTableMapping."Table Name" := AllObj."Object Name"
MigrationTableMapping."Table Name" := AllObj.Name
else
MigrationTableMapping."Table Name" := CopyStr(SourceTableName, 1, MaxStrLen(MigrationTableMapping."Table Name"));

Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/HybridBaseDeployment/app/src/pages/CloudMigSelectTables.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ page 40041 "Cloud Mig - Select Tables"
exit;
end;

AllObj.SetFilter("Object Name", '@*' + TableNameFilter + '*');
AllObj.SetFilter(Name, '@*' + TableNameFilter + '*');
CloudMigReplicateDataMgt.LookupTableData(Rec, TableNameFilter, AllObj);
CurrPage.Update(false);
end;
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/HybridBaseDeployment/app/src/pages/MigrationTableMapping.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ page 4009 "Migration Table Mapping"
exit(false);

AllObjects.GetRecord(AllObj);
Text := AllObj."Object Name";
Text := AllObj.Name;
if (Rec."Table ID" <> AllObj."Object ID") and (Rec."Target Table Type" = Rec."Target Table Type"::"Table Extension") then
// Partners often have the table and table extension that have same ID and they need to map both
// Just the ID is the same, the table extended is different
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/HybridBaseDeployment/app/src/tables/MigrationTableMapping.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ table 4009 "Migration Table Mapping"
end;
}

field(3; "Table Name"; Text[30])
field(3; "Table Name"; Text[100])
{
DataClassification = SystemMetadata;
Description = 'Specifies the name of the table to map.';
Expand Down
22 changes: 11 additions & 11 deletions src/Apps/W1/INTaxEngine/app/TaxEngine-Core/src/Core/Codeunit/AppObjectHelper.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ using System.Reflection;

codeunit 20130 "App Object Helper"
{
procedure GetObjectName(Type: ObjectType; ObjectID: Integer): Text[30];
procedure GetObjectName(Type: ObjectType; ObjectID: Integer): Text;
var
AllObj: Record AllObj;
begin
Expand All @@ -19,7 +19,7 @@ codeunit 20130 "App Object Helper"
AllObj.SetRange("Object Type", ObjectTypeToOption(Type));
AllObj.SetRange("Object ID", ObjectID);
if AllObj.FindFirst() then
exit(AllObj."Object Name");
exit(AllObj.Name);
end;

procedure GetFieldName(TableID: Integer; FieldID: Integer): Text[30];
Expand Down Expand Up @@ -156,7 +156,7 @@ codeunit 20130 "App Object Helper"
end;
end;

procedure SearchObject(Type: ObjectType; var ObjectID: Integer; var ObjectName: Text[30]);
procedure SearchObject(Type: ObjectType; var ObjectID: Integer; var ObjectName: Text[100]);
var
AllObj: Record AllObj;
TmpObjectID: Integer;
Expand All @@ -169,12 +169,12 @@ codeunit 20130 "App Object Helper"
if IsInteger then
AllObj.SetRange("Object ID", TmpObjectID)
else begin
AllObj.SetCurrentKey("Object Type", "Object Name");
AllObj.SetFilter("Object Name", '%1', '@' + ObjectName + '*');
AllObj.SetCurrentKey("Object Type", Name);
AllObj.SetFilter(Name, '%1', '@' + ObjectName + '*');
end;
if AllObj.FindFirst() then begin
ObjectID := AllObj."Object ID";
ObjectName := AllObj."Object Name";
ObjectName := AllObj.Name;
end else
if IsInteger and (TmpObjectID = 0) then begin
ObjectID := 0;
Expand All @@ -183,7 +183,7 @@ codeunit 20130 "App Object Helper"
Error(InvalidObjectNoErr, ObjectName);
end;

procedure GetObjectID(Type: ObjectType; Name: Text[30]): Integer;
procedure GetObjectID(Type: ObjectType; Name: Text): Integer;
var
AllObj: Record AllObj;
begin
Expand All @@ -192,12 +192,12 @@ codeunit 20130 "App Object Helper"

AllObj.Reset();
AllObj.SetRange("Object Type", ObjectTypeToOption(Type));
AllObj.SetRange("Object Name", Name);
AllObj.SetRange(Name, Name);
if AllObj.FindFirst() then
exit(AllObj."Object ID");
end;

procedure OpenObjectLookup(Type: ObjectType; SearchText: Text; var ObjectID: Integer; var ObjectName: Text[30]);
procedure OpenObjectLookup(Type: ObjectType; SearchText: Text; var ObjectID: Integer; var ObjectName: Text[100]);
var
AllObj: Record AllObj;
begin
Expand All @@ -209,13 +209,13 @@ codeunit 20130 "App Object Helper"
AllObj.Find('=');
end else
if SearchText <> '' then begin
AllObj."Object Name" := CopyStr(SearchText, 1, 30);
AllObj.Name := CopyStr(SearchText, 1, MaxStrLen(AllObj.Name));
AllObj.Find('<>=');
end;

if Page.RunModal(Page::"All Objects", AllObj) = Action::LookupOK then begin
ObjectID := AllObj."Object ID";
ObjectName := AllObj."Object Name";
ObjectName := AllObj.Name;
end;
end;

Expand Down
6 changes: 3 additions & 3 deletions src/Apps/W1/INTaxEngine/app/TaxEngine-Core/src/Lookup/Page/ScriptSymbolLookupDialog.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,12 @@ page 20142 "Script Symbol Lookup Dialog"
end;

[IntegrationEvent(false, false)]
procedure OnValidateLookupTableName(CaseID: Guid; ScriptID: Guid; var TableID: Integer; var TableName: Text[30]; IsTransactionTable: Boolean)
procedure OnValidateLookupTableName(CaseID: Guid; ScriptID: Guid; var TableID: Integer; var TableName: Text[100]; IsTransactionTable: Boolean)
begin
end;

[IntegrationEvent(false, false)]
procedure OnLookupLookupTableName(CaseID: Guid; ScriptID: Guid; var TableID: Integer; var TableName: Text[30]; SearchText: Text)
procedure OnLookupLookupTableName(CaseID: Guid; ScriptID: Guid; var TableID: Integer; var TableName: Text[100]; SearchText: Text)
begin
end;

Expand All @@ -575,7 +575,7 @@ page 20142 "Script Symbol Lookup Dialog"
ShowFullLoookup: Boolean;
[InDataSet]
IsSymbolType: Boolean;
LookupTableName: Text[30];
LookupTableName: Text[100];
LookupTableFieldName: Text[30];
AttributeName2: Text[30];
LookupTableFilters2: Text;
Expand Down
24 changes: 12 additions & 12 deletions ...NTaxEngine/app/TaxEngine-JsonExchange/src/ExportImport/TaxJsonDeserialization.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ codeunit 20361 "Tax Json Deserialization"
case property of
'TableName':
begin
TableID := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TableID := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
if not TaxEntity.Get(TableID, TaxType) then begin
TaxEntity.Init();
TaxEntity."Tax Type" := TaxType;
Expand Down Expand Up @@ -151,13 +151,13 @@ codeunit 20361 "Tax Json Deserialization"
TaxAttribute.FieldNo(Type),
JToken2Text(JToken));
'LookupTable':
TaxAttribute."Refrence Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TaxAttribute."Refrence Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
'LookupField':
TaxAttribute."Refrence Field ID" := AppObjectHelper.GetFieldID(
TaxAttribute."Refrence Table ID",
JToken2Text30(JToken));
'LookupPage':
TaxAttribute."Lookup Page ID" := AppObjectHelper.GetObjectID(ObjectType::Page, JToken2Text30(JToken));
TaxAttribute."Lookup Page ID" := AppObjectHelper.GetObjectID(ObjectType::Page, JToken2Text(JToken));
'VisibleOnInterface':
TaxAttribute."Visible on Interface" := JToken.AsValue().AsBoolean();
'GroupedInSubLedger':
Expand Down Expand Up @@ -253,7 +253,7 @@ codeunit 20361 "Tax Json Deserialization"
begin
EntityAttributeMapping."Entity ID" := AppObjectHelper.GetObjectID(
ObjectType::Table,
JToken2Text30(JToken));
JToken2Text(JToken));
EntityAttributeMapping."Entity Name" :=
AppObjectHelper.GetObjectName(ObjectType::Table, EntityAttributeMapping."Entity ID");
end;
Expand Down Expand Up @@ -625,13 +625,13 @@ codeunit 20361 "Tax Json Deserialization"
UseCase."Indentation Level" := JToken.AsValue().AsInteger();
'TaxEntity':
begin
UseCase."Tax Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
UseCase."Tax Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
GlobalUseCase := UseCase;
UseCase.Modify();
end;
'PostingTableName':
begin
UseCase."Posting Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
UseCase."Posting Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
GlobalUseCase := UseCase;
UseCase.Modify();
end;
Expand Down Expand Up @@ -812,7 +812,7 @@ codeunit 20361 "Tax Json Deserialization"
end;
'TableName':
begin
TaxPostingSetup."Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TaxPostingSetup."Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
TaxPostingSetup.Modify();
end;
'FieldName':
Expand Down Expand Up @@ -961,7 +961,7 @@ codeunit 20361 "Tax Json Deserialization"
case property of
'TableName':
begin
TaxInsertRecord."Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TaxInsertRecord."Table ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
TaxInsertRecord.Modify();
end;
'RunTrigger':
Expand Down Expand Up @@ -1428,7 +1428,7 @@ codeunit 20361 "Tax Json Deserialization"
'SourceType':
Evaluate(ScriptSymbolLookup."Source Type", JToken2Text250(JToken));
'TableName', 'RecordTableName':
ScriptSymbolLookup."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
ScriptSymbolLookup."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
'ComponentName':
begin
ScriptSymbolLookup."Source Field ID" := GetComponentID(GlobalUseCase."Tax Type", JToken2Text30(JToken));
Expand Down Expand Up @@ -1497,8 +1497,8 @@ codeunit 20361 "Tax Json Deserialization"
case property of
'TableName':
begin
TaxTableRelation."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TaxTableRelation."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text30(JToken));
TaxTableRelation."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
TaxTableRelation."Source ID" := AppObjectHelper.GetObjectID(ObjectType::Table, JToken2Text(JToken));
end;
'TableFilters':
begin
Expand Down Expand Up @@ -2276,7 +2276,7 @@ codeunit 20361 "Tax Json Deserialization"
'TableName':
ActionLoopThroughRecords."Table ID" := AppObjectHelper.GetObjectID(
ObjectType::Table,
JToken2Text30(JToken));
JToken2Text(JToken));
'RecordVariableName':
;
'TableFilters':
Expand Down
2 changes: 1 addition & 1 deletion ...ine/app/TaxEngine-PostingHandler/src/PostingManagement/page/TaxInsertRecordDialog.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ page 20334 "Tax Insert Record Dialog"
InsertRecord: Record "Tax Insert Record";
AppObjectHelper: Codeunit "App Object Helper";
ScriptSymbolsMgmt: Codeunit "Script Symbols Mgmt.";
IntoTableName: Text[30];
IntoTableName: Text[100];

procedure SetCurrentRecord(var InsertRecord2: Record "Tax Insert Record");
begin
Expand Down
2 changes: 1 addition & 1 deletion ...NTaxEngine/app/TaxEngine-PostingHandler/src/PostingManagement/page/UseCasePosting.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ page 20337 "Use Case Posting"
LookupDialogMgmt: Codeunit "Lookup Dialog Mgmt.";
LookupEntityMgmt: Codeunit "Lookup Entity Mgmt.";
AppObjectHelper: Codeunit "App Object Helper";
PostingTableName: Text[30];
PostingTableName: Text[100];
PostingTableFilters: Text;
EmptyGuid: Guid;

Expand Down
2 changes: 1 addition & 1 deletion .../INTaxEngine/app/TaxEngine-ScriptHandler/src/Actions/page/ActionLoopThroughRecDlg.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ page 20171 "Action Loop Through Rec. Dlg"
LookupSerialization: Codeunit "Lookup Serialization";
LookupDialogMgmt: Codeunit "Lookup Dialog Mgmt.";
ScriptSymbolsMgmt: Codeunit "Script Symbols Mgmt.";
FromTableName: Text[30];
FromTableName: Text[100];
TableFilters: Text;
TableSorting2: Text;
IndexVariable2: Text[30];
Expand Down
2 changes: 1 addition & 1 deletion ...s/W1/INTaxEngine/app/TaxEngine-ScriptHandler/src/Script/Page/ScriptRecordVariable.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ page 20201 "Script Record Variable"

var
AppObjectHelper: Codeunit "App Object Helper";
RecordTableName: Text[30];
RecordTableName: Text[100];

local procedure UpdateControls();
begin
Expand Down
2 changes: 1 addition & 1 deletion ...e/app/TaxEngine-TaxTypeHandler/src/GenericAttribute/table/EntityAttributeMapping.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ table 20232 "Entity Attribute Mapping"
DataClassification = EndUserIdentifiableInformation;
Caption = 'Attribute Name';
}
field(4; "Entity Name"; Text[30])
field(4; "Entity Name"; Text[100])
{
DataClassification = SystemMetadata;
Caption = 'Entity Name';
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/W1/INTaxEngine/app/TaxEngine-TaxTypeHandler/src/TaxType/Table/TaxEntity.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ table 20257 "Tax Entity"
Caption = 'Tax Type';
TableRelation = "Tax Type".Code;
}
field(3; "Table Name"; Text[30])
field(3; "Table Name"; Text[100])
{
DataClassification = SystemMetadata;
Caption = 'Table Name';
Expand Down
4 changes: 2 additions & 2 deletions ...INTaxEngine/app/TaxEngine-TaxTypeHandler/src/TaxType/attributes/page/TaxAttribute.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ page 20257 "Tax Attribute"
DatatypeMgmt: Codeunit "Use Case Data Type Mgmt.";
ValuesDrillDownVisible: Boolean;
UnitOfMeasureVisible: Boolean;
TableNameText2: Text[30];
PageNameText2: Text[30];
TableNameText2: Text[100];
PageNameText2: Text[100];
FieldNameText2: Text[30];

local procedure UpdateControlVisibility();
Expand Down
Loading
Loading