Extract AU Withholding Tax code

[Alexander-Ya]

What & why

Linked work

Fixes AB#636621

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Accessibility} \quad \color{gray}{\texttt{\small Iteration\ 9}}$

The tooltip on 'Purch.

• Tax Invoice' contradicts the action caption and RunObject by saying it creates a "purchase tax credit invoice." This mislabels the action in the Role Center. Update the tooltip to describe a purchase tax invoice instead.

Suggested change

	ToolTip = 'Create a new purchase tax credit invoice.';
	ToolTip = 'Create a new purchase tax invoice.';

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 9}}$

The OnPrepareLineOnBeforeSetInvoiceDiscountPosting subscriber queries Purch.

Inv. Header and then WHT Entry before checking PurchLine."Prepayment Line". This subscriber runs while preparing purchase lines, so non-prepayment lines still pay those database round-trips. Add the cheap Prepayment Line guard first and only run the queries when it passes.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

    begin
        if not PurchLine."Prepayment Line" then
            exit;

        PrepmtPurchInvHeader.Reset();
        PrepmtPurchInvHeader.SetRange("Prepayment Order No.", PurchLine."Document No.");
        PrepmtPurchInvHeader.SetRange("Prepayment Invoice", true);
        if PrepmtPurchInvHeader.FindSet() then
            repeat
                PrepmtWHTEntry.SetRange("Document Type", PrepmtWHTEntry."Document Type"::Invoice);
                PrepmtWHTEntry.SetRange("Document No.", PrepmtPurchInvHeader."No.");
                PrepmtWHTEntry.SetRange("Gen. Bus. Posting Group", GenPostingSetup."Gen. Bus. Posting Group");
                PrepmtWHTEntry.SetRange("Gen. Prod. Posting Group", GenPostingSetup."Gen. Prod. Posting Group");
                if PrepmtWHTEntry.FindSet() then
                    repeat
                        TotalWHTAmountToBeDeductedLCY := TotalWHTAmountToBeDeductedLCY + PrepmtWHTEntry."Unrealized Amount (LCY)";
                        TotalWHTAmtTobeDeducted := TotalWHTAmtTobeDeducted + PrepmtWHTEntry."Unrealized Amount";
                    until PrepmtWHTEntry.Next() = 0;
            until PrepmtPurchInvHeader.Next() = 0;

        GLSetup.Get();
        if GLSetup."Additional Reporting Currency" <> '' then
            TotalWHTAmountToBeDeductedACY :=
              CurrExchRate.ExchangeAmtLCYToFCY(
                PurchHeader."Posting Date", GLSetup."Additional Reporting Currency",
                TotalWHTAmtTobeDeducted, 0);

        TotalAmount := TotalAmount + TotalWHTAmountToBeDeductedLCY;
        TotalAmountACY := TotalAmountACY + TotalWHTAmountToBeDeductedACY;
    end;

Knowledge:

• microsoft/knowledge/performance/guard-event-subscribers-before-db-call.md
• microsoft/knowledge/performance/apply-guards-before-get.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Accessibility} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

The action caption `Posted Purch.

Tax Credit Memocontains a double space, which shows up as a visible typo in the Role Center. Change the caption text toPosted Purch. Tax Credit Memo`.

Suggested change

	Caption = 'Posted Purch. Tax Credit Memo';
	Caption = 'Posted Purch. Tax Credit Memo';

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Accessibility} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

The newly added AU/NZ Statement action has no ToolTip, so this Role Center entry loses the hover/help text that the same report action already provides elsewhere.

Add the standard report tooltip here as well.

Suggested change

	action("AU/NZ Statement")
	{
	ApplicationArea = Basic, Suite;
	Caption = 'AU/NZ Statement';
	RunObject = Report "AU/NZ Statement";
	}
	action("AU/NZ Statement")
	{
	ApplicationArea = Basic, Suite;
	Caption = 'AU/NZ Statement';
	RunObject = Report "AU/NZ Statement";
	ToolTip = 'Print the report of accounts receivable and accounts payable based on the selections you make in the report request window.';
	}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

Both added FindSet() loops read only a small subset of fields from wide records (`Purch.

Inv. HeaderandWHT Entry), but no SetLoadFields(...)` is declared before the reads. That causes full-row materialization on every iteration instead of loading just the fields used by the accumulation logic.

Suggested change

	PrepmtPurchInvHeader.Reset();
	PrepmtPurchInvHeader.SetRange("Prepayment Order No.", PurchLine."Document No.");
	PrepmtPurchInvHeader.SetRange("Prepayment Invoice", true);
	if PrepmtPurchInvHeader.FindSet() then
	repeat
	PrepmtWHTEntry.SetRange("Document Type", PrepmtWHTEntry."Document Type"::Invoice);
	PrepmtWHTEntry.SetRange("Document No.", PrepmtPurchInvHeader."No.");
	PrepmtWHTEntry.SetRange("Gen. Bus. Posting Group", GenPostingSetup."Gen. Bus. Posting Group");
	PrepmtWHTEntry.SetRange("Gen. Prod. Posting Group", GenPostingSetup."Gen. Prod. Posting Group");
	if PrepmtWHTEntry.FindSet() then
	PrepmtPurchInvHeader.Reset();
	PrepmtPurchInvHeader.SetLoadFields("No.");
	PrepmtPurchInvHeader.SetRange("Prepayment Order No.", PurchLine."Document No.");
	PrepmtPurchInvHeader.SetRange("Prepayment Invoice", true);
	if PrepmtPurchInvHeader.FindSet() then
	repeat
	PrepmtWHTEntry.SetLoadFields("Unrealized Amount (LCY)", "Unrealized Amount");
	PrepmtWHTEntry.SetRange("Document Type", PrepmtWHTEntry."Document Type"::Invoice);
	PrepmtWHTEntry.SetRange("Document No.", PrepmtPurchInvHeader."No.");
	PrepmtWHTEntry.SetRange("Gen. Bus. Posting Group", GenPostingSetup."Gen. Bus. Posting Group");
	PrepmtWHTEntry.SetRange("Gen. Prod. Posting Group", GenPostingSetup."Gen. Prod. Posting Group");
	if PrepmtWHTEntry.FindSet() then

Knowledge:

• microsoft/knowledge/performance/use-setloadfields-for-partial-records.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Security} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

The new OnAfterInitGenJnlLineAmountFieldsFromTotalLines publisher is raised inside sales invoice posting without [CommitBehavior(CommitBehavior::Ignore)].

A subscriber can call Commit() during posting and persist partial state before later posting code fails; add CommitBehavior::Ignore on the publisher to preserve rollback semantics.

Suggested fix (apply manually — could not be anchored as a one-click suggestion):

[CommitBehavior(CommitBehavior::Ignore)]
[IntegrationEvent(false, false)]
local procedure OnAfterInitGenJnlLineAmountFieldsFromTotalLines(var GenJnlLine: Record "Gen. Journal Line"; var SalesHeader: Record "Sales Header"; var TotalSalesLine: Record "Sales Line"; var TotalSalesLineLCY: Record "Sales Line")

Knowledge:

• microsoft/knowledge/security/commitbehavior-attribute-scopes-explicit-commits.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

TotalSalesLineLCY is declared as Record "Sales Line" temporary in this new codeunit, but the parameter name does not start with Temp.

The same non-conforming temporary-record name is repeated in the subscriber signature, PostWHT, and InsertGenJournalWHT, which hides the fact that the record is in-memory only.

Knowledge:

• microsoft/knowledge/style/temporary-variable-temp-prefix.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 10}}$

This new codeunit calls its own procedures as bare identifiers (PostWHT, InsertGenJournalWHT, CheckWHTApplication, UpdateTaxForPostedDoc) instead of qualifying them with this..

In a codeunit, this. is the required self-reference convention and makes the local call target unambiguous.

Knowledge:

• microsoft/knowledge/style/this-keyword-in-codeunits.md

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}