[master] - Invalid SEPA export file format when SEPA Non-Euro Export enabled

[MSNehaNawal]

Bug 641697: [master][All-e]Invalid SEPA export file format when SEPA Non-Euro Export enabled - Copy

Fixes AB#641697

[github-actions]

Copilot PR Review

Iteration 2 · Outcome: completed

All six sub-skills ran to completion; none found applicable knowledge-domain concerns in the diff. The change is a scoped SEPA charge-bearer/service-level fix (control-flow only) plus test additions across BC country layers — no security, privacy, upgrade, UI, performance, or style-rule triggers were present.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

This PR changes the pain.001.001.09 credit transfer XMLPorts so SvcLvl/Cd is SEPA only when ChrgBr is SLEV; otherwise it writes NURG. That matches the bug: with SEPA Non-Euro Export enabled, the fill buffer sets charge bearer to SHAR, and the old SEPA service level created an invalid ISO 20022 combination. The change is narrow and is applied to the country XMLPort copies that have this pain.001.001.09 implementation. The normal euro path still uses SLEV and therefore keeps SEPA. Direct debit exporters use the established SEPA/SLEV path and do not need the same change.

Suggestions

S1 - Use a real non-euro test payment
The new test enables SEPA Non-Euro Export, but CreateGenJnlLine still uses the existing EURCode helper. Create a real non-euro currency line and assert the related ChrgBr and InstdAmt @Ccy values too, so the test covers the customer scenario and the schema-sensitive combination.

Risk assessment and necessity

Risk: This is bank payment export XML, so a wrong value can make payment files fail bank validation. The code change is small and does not change public APIs, events, amounts, or the InstdAmt Ccy attribute. The main regression surface is the generated PmtTpInf/SvcLvl/Cd value for euro and non-euro credit transfers across the copied country XMLPorts.

Necessity: The linked bug is valid and clear: foreign-currency SEPA credit transfer exports are rejected because SvcLvl=SEPA is combined with ChrgBr=SHAR. Changing the service level to NURG for the non-SLEV branch targets that invalid XML element directly. A regression test is present, but it should use an actual non-euro payment to prove the exact customer case.

---

[AI-PR-REVIEW] version=1 system=github pr=9209 round=1 by=alexei-dobriansky at=2026-07-09 lastSha=7243980fbe2d44c87d7a45fd7279c7544725e6c1 suggestions=S1