Skip to content

[master] - Calculate Calendar reports missing from Work/Machine Center Cards and missing filter fields on request pages#9177

Open
neeleshsinghal wants to merge 4 commits into
microsoft:mainfrom
neeleshsinghal:bugs/Bug-641376-Calculate-Calendar-reports-missing
Open

[master] - Calculate Calendar reports missing from Work/Machine Center Cards and missing filter fields on request pages#9177
neeleshsinghal wants to merge 4 commits into
microsoft:mainfrom
neeleshsinghal:bugs/Bug-641376-Calculate-Calendar-reports-missing

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Workitem: Bug 641376: [master] [ALL-E] Calculate Calendar reports missing from Work/Machine Center Cards and missing filter fields on request pages

Fixes AB#641376

Issue: Calculate Work/Machine Center Calendar reports aren't accessible from the Work Center Card (99000754) and Machine Center Card (99000760), and their request pages lack useful filter fields.

Cause: Neither card page defines an area(processing) for the calendar action, and both reports declare RequestFilterFields = "No."; only, omitting Work Center Group Code and Work Center No..

Solution: Added an area(processing) with the calendar action (RunPageOnRec = true) on both card pages, and extended RequestFilterFields on report 99001046 with "Work Center Group Code" and on report 99001045 with "Work Center No.".

@github-actions github-actions Bot added From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item labels Jul 7, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 7, 2026
@neeleshsinghal neeleshsinghal reopened this Jul 7, 2026
@neeleshsinghal neeleshsinghal reopened this Jul 8, 2026
@neeleshsinghal neeleshsinghal reopened this Jul 8, 2026
@neeleshsinghal neeleshsinghal marked this pull request as ready for review July 8, 2026 05:10
@neeleshsinghal neeleshsinghal requested a review from a team July 8, 2026 05:10
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 4 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@neeleshsinghal neeleshsinghal added the SCM GitHub request for SCM area label Jul 8, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR adds Calculate Calendar actions to the Work Center Card and Machine Center Card, and adds request-page filters to the two calendar reports. The Work Center Card action runs report 99001046 Calculate Work Center Calendar with the current work center filtered by No.. The Machine Center Card action runs report 99001045 Calc. Machine Center Calendar with the current machine center filtered by No.. The report request filters are also bound to the right fields: Work Center Group Code for work centers and Work Center No. for machine centers.

The implementation addresses the root cause in the linked bug. The added tests cover invoking both card actions and filtering both request pages, and the app build checks for the touched W1, IT, and CZ areas are passing.

Suggestions

None.

Risk assessment and necessity

Risk: Low. The changed behavior is limited to new UI entry points and extra report request filters. The reports still calculate calendars through the existing report logic, and the card actions narrow the table view before running the report.

Necessity: Required. Without this change, users who start from a Work Center Card or Machine Center Card must go back to the list page, and the request pages do not expose the useful parent/group filters described in the bug.


[AI-PR-REVIEW] version=1 system=github pr=9177 round=1 by=alexei-dobriansky sha=9594fe7fb4faa0d40af4f6763475797f8c2b0c49

@neeleshsinghal neeleshsinghal enabled auto-merge July 9, 2026 05:08
auto-merge was automatically disabled July 9, 2026 10:30

Pull request was closed

@neeleshsinghal neeleshsinghal reopened this Jul 9, 2026
@neeleshsinghal neeleshsinghal enabled auto-merge July 9, 2026 10:31
Comment thread src/Layers/W1/Tests/SCM-Manufacturing/SCMManufacturing.Codeunit.al
Comment thread src/Layers/W1/Tests/SCM-Manufacturing/SCMManufacturing.Codeunit.al
auto-merge was automatically disabled July 10, 2026 21:04

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants