Reproduce PR #285 dependency security updates - #288
Conversation
Co-authored-by: dbezic <50911161+dbezic@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The ws override floor is set to ^8.21.0 while the PR description/lockfile indicate 8.21.3 is the intended patched minimum, which could allow future installs to resolve an older 8.21.x.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Recreates PR #285’s dependency security remediation by updating pnpm override constraints (and the Hono catalog floor) so vulnerable transitive versions are forced to patched releases across the monorepo.
Changes:
- Raised the workspace catalog minimum for
honoto^4.13.5. - Added/updated pnpm overrides for
axios,protobufjs,langsmith,@grpc/grpc-js, andwsto enforce patched minimum versions. - Updated the lockfile to preserve the resolved dependency graph/tarball metadata under the new override set.
File summaries
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates hono catalog minimum and adds security-focused transitive overrides. |
| package.json | Mirrors security overrides in root pnpm.overrides for consistent enforcement. |
| pnpm-lock.yaml | Captures the resulting override set and resolved versions in the workspace lockfile. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The PR claims an exact reproduction of PR #285, but the ws override differs from PR #285’s diff and should be reconciled (align versions or update the PR description).
Review details
Suppressed comments (5)
Previously missed (1) — in code that hasn't changed since the last review.
pnpm-workspace.yaml:102
- There’s an extra space before the period in “security remediation .”, which reads like a typo.
This issue also appears in the following locations of the same file:
- line 111
- line 117
package.json:72
- The PR description says this branch reproduces PR #285 exactly, but PR #285’s diff sets the ws override to ^8.21.0, while this change sets it to ^8.21.3. If exact reproduction is required, align the ws override version; otherwise, the PR description should be updated to reflect the intentional deviation.
"langsmith": "^0.8.0",
"protobufjs": "^7.5.6",
"uuid": "^10.0.0",
"ws": "^8.21.3",
"zod": "^4.1.12"
pnpm-workspace.yaml:128
- The PR description claims all changed files match PR #285 exactly, but PR #285’s diff sets the ws override to ^8.21.0, whereas this change sets it to ^8.21.3. Either align this override to PR #285 for a true reproduction, or update the PR description to note the version bump.
# ws - security remediation. Forces the transitive ws@8.20.0 up to the patched
# 8.21.3, which fixes CVE-2026-48779 (memory exhaustion DoS from tiny
# fragments and data chunks). Remove once the transitive parents resolve a
# patched ws by default.
"ws": "^8.21.3"
pnpm-workspace.yaml:111
- There’s an extra space before the period in “security remediation .”, which reads like a typo.
# langsmith - security remediation . Forces the transitive langsmith@0.5.25 up to the patched
pnpm-workspace.yaml:117
- There’s an extra space before the period in “security remediation .”, which reads like a typo.
# @grpc/grpc-js - security remediation . Forces the transitive @grpc/grpc-js@1.14.3 up to the
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
The ws constraint differs from PR #285 despite the stated exact-reproduction goal.
Review details
Suppressed comments (1)
package.json:71
- The stated goal is to preserve PR #285 exactly, but its final head uses
^8.21.0for this override (and inpnpm-workspace.yamland the lockfile), while only the resolved lock entry is 8.21.3. This changes the minimum constraint and means none of the three files is an exact copy. Either restore^8.21.0consistently or update the PR description to document that the stronger floor is an intentional deviation.
"ws": "^8.21.3",
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Recreates PR #285 on a new branch, preserving all three changed files exactly.
axios,protobufjs,langsmith,@grpc/grpc-js,hono, andws.4.13.5.