Extract PowerShell code from E2E.yaml into local actions #2029

Copilot · 2025-11-18T14:04:56Z

❔What, Why & How

Refactored E2E.yaml by extracting 13 inline PowerShell code blocks into 7 reusable local composite actions, reducing the workflow file from 453 to 358 lines. This improves maintainability, reduces duplication, and adds proper error handling and PowerShell best practices to all scripts.

Created Actions (in .github/actions/):

E2ECheckSecrets - Secret validation + githubOwner/maxParallel calculation
E2ESetupRepositories - Test repository initialization
E2EAnalyze - Test matrix generation (public/private runs, releases, scenarios)
E2ECalculateRepoName - Random repo name generation
E2ECalculateTestParams - Template + credential parameter resolution
E2ERunScenario - Scenario test execution
E2ERunTest - Test-AL-Go.ps1 and Test-AL-Go-Upgrade.ps1 execution

Each action includes PowerShell script with proper error handling, action.yaml descriptor, and README documentation. All actions are placed in .github/actions/ to avoid confusion with the actions that AL-Go ships. Actions call PowerShell scripts directly without wrapper layers.

Code Quality Improvements:

Added $ErrorActionPreference = "Stop", $ProgressPreference = "SilentlyContinue", and Set-StrictMode -Version 2.0 to all PowerShell scripts
Fixed inconsistent variable casing for PowerShell best practices
Changed backslash to forward slash in file paths for cross-platform compatibility
Removed trailing whitespace
Removed invalid shell inputs from composite action calls (composite actions define shell in action.yaml)
Removed dead code in E2ECalculateTestParams.ps1 (unreachable elseif block)
Centralized contentPath calculation logic in E2ECalculateTestParams action to eliminate duplication
All pre-commit checks passing

Related to issue: [Issue number to be added]

✅ Checklist

Add tests (E2E, unit tests)
Update RELEASENOTES.md
Update documentation (e.g. for new settings or scenarios)
Add telemetry

Original prompt

Can you please extract all the powershell code from E2E.yaml into local actions?

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mazhelez <[email protected]>

.github/workflows/E2E.yaml

Actions/E2ECheckSecrets/action.yaml

Co-authored-by: mazhelez <[email protected]>

mazhelez · 2025-11-19T14:55:36Z

.github/actions/E2ECalculateTestParams/E2ECalculateTestParams.ps1

+    [string] $matrixStyle = '',
+    [Parameter(HelpMessage = "Matrix OS (windows or linux)", Mandatory = $false)]
+    [string] $matrixOs = '',
+    [Parameter(HelpMessage = "Admin center API credentials secret", Mandatory = $false)]


@copilot please, fix

.github/actions/E2ECheckSecrets/E2ECheckSecrets.ps1

+    [string] $e2ePrivateKey = '',
+    [Parameter(HelpMessage = "ALGOAUTHAPP secret value", Mandatory = $false)]
+    [string] $algoAuthApp = '',
+    [Parameter(HelpMessage = "adminCenterApiCredentials secret value", Mandatory = $false)]


.github/actions/E2ECheckSecrets/E2ECheckSecrets.ps1

+    [string] $adminCenterApiCredentials = '',
+    [Parameter(HelpMessage = "E2E_GHPackagesPAT secret value", Mandatory = $false)]
+    [string] $e2eGHPackagesPAT = '',
+    [Parameter(HelpMessage = "E2EAZURECREDENTIALS secret value", Mandatory = $false)]


.github/actions/E2ERunScenario/E2ERunScenario.ps1

+    [string] $pteTemplate,
+    [Parameter(HelpMessage = "AppSource template", Mandatory = $true)]
+    [string] $appSourceTemplate,
+    [Parameter(HelpMessage = "Admin center API credentials", Mandatory = $true)]


.github/actions/E2ERunScenario/E2ERunScenario.ps1

+    [string] $appSourceTemplate,
+    [Parameter(HelpMessage = "Admin center API credentials", Mandatory = $true)]
+    [string] $adminCenterApiCredentials,
+    [Parameter(HelpMessage = "Azure credentials", Mandatory = $true)]


.github/actions/E2ERunScenario/E2ERunScenario.ps1

.github/actions/E2ERunTest/E2ERunTest.ps1

mazhelez · 2025-11-19T11:38:06Z

@copilot Would you please fix the code scanning issues, as well as the issues reported by the pre-commit check.

Co-authored-by: mazhelez <[email protected]>

Copilot · 2025-11-19T11:44:51Z

@copilot Would you please fix the code scanning issues, as well as the issues reported by the pre-commit check.

Fixed all code scanning and pre-commit issues:

Pre-commit fixes:

Removed trailing whitespace from E2ERunScenario.ps1 and E2ERunTest.ps1

Code quality improvements:

Added $ErrorActionPreference = "Stop", $ProgressPreference = "SilentlyContinue", and Set-StrictMode -Version 2.0 to all 7 E2E PowerShell scripts
Fixed inconsistent variable casing ($errorActionPreference → $ErrorActionPreference)
Removed unnecessary quotes around $ENV:GITHUB_REPOSITORY_OWNER
Changed backslash to forward slash in file paths for cross-platform compatibility (e.g., e2eTests\orgmap.json → e2eTests/orgmap.json)

All pre-commit checks now pass, and scripts follow PowerShell best practices. Commit: e6a2b0d

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.powershellgallery.com
- Triggering command: pwsh -Command Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser -SkipPublisherCheck (dns block)
- Triggering command: pwsh -Command Set-PSRepository -Name PSGallery -InstallationPolicy Trusted; Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser (dns block)
- Triggering command: pwsh -Command Register-PSRepository -Default -ErrorAction SilentlyContinue; Set-PSRepository -Name PSGallery -InstallationPolicy Trusted; Install-Module -Name PSScriptAnalyzer -Force -Scope CurrentUser (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull Request Overview

This PR refactors the E2E.yaml workflow by extracting 13 inline PowerShell code blocks into 7 reusable local composite actions, reducing the workflow file from 453 to 358 lines. The refactoring improves maintainability, reduces duplication, and adds proper error handling and PowerShell best practices to all scripts.

Key changes:

Extracted secret validation, repository setup, test matrix generation, and test execution logic into separate actions
Added error handling patterns with try-catch blocks and proper error propagation
Standardized PowerShell script headers with $ErrorActionPreference, $ProgressPreference, and Set-StrictMode

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
.github/workflows/E2E.yaml	Replaced inline PowerShell blocks with calls to composite actions
.github/actions/E2ECheckSecrets/*	Action for validating required secrets and calculating test parameters
.github/actions/E2ESetupRepositories/*	Action for initializing test repositories
.github/actions/E2EAnalyze/*	Action for generating test matrices (public/private runs, releases, scenarios)
.github/actions/E2ECalculateRepoName/*	Action for generating random repository names
.github/actions/E2ECalculateTestParams/*	Action for resolving template and credential parameters
.github/actions/E2ERunScenario/*	Action for executing scenario tests
.github/actions/E2ERunTest/*	Action for executing Test-AL-Go.ps1 and Test-AL-Go-Upgrade.ps1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-19T13:11:03Z

.github/workflows/E2E.yaml

-        env:
+        uses: ./.github/actions/E2ECheckSecrets
+        with:
+          shell: pwsh


The shell input is not valid for composite actions. Composite actions define their shell in the action.yaml file. This line should be removed as it will be ignored by GitHub Actions and may cause confusion.

Suggested change

shell: pwsh

@copilot please fix

Removed all invalid shell inputs from composite action calls. Composite actions define their shell in action.yaml, not as inputs. Also removed dead code in E2ECalculateTestParams.ps1 and moved contentPath calculation logic into the action to avoid duplication. Commit: 32499d0

Copilot · 2025-11-19T13:11:03Z

.github/workflows/E2E.yaml

-          . (Join-Path "." "e2eTests/SetupRepositories.ps1") -githubOwner '${{ needs.Check.outputs.githubowner }}' -bcContainerHelperVersion $ENV:_bcContainerHelperVersion
+        uses: ./.github/actions/E2ESetupRepositories
+        with:
+          shell: pwsh


The shell input is not valid for composite actions. Composite actions define their shell in the action.yaml file. This line should be removed.

Suggested change

shell: pwsh

.github/workflows/E2E.yaml

Copilot · 2025-11-19T13:11:07Z

.github/workflows/E2E.yaml

+          contentPath: ${{ matrix.type == 'appSourceApp' && 'appsourceapp' || 'pte' }}



The contentPath is being calculated in the workflow using conditional expressions, but E2ECalculateTestParams action also has logic to calculate contentPath. This creates duplicate logic and potential inconsistency. Consider removing the inline calculation and letting the action handle it based on matrixType.

Suggested change

contentPath: ${{ matrix.type == 'appSourceApp' && 'appsourceapp' || 'pte' }}

@copilot please fix the comment

Already fixed in commit 32499d0. The duplicate contentPath calculation has been removed from the workflow. The action now calculates contentPath based on matrixType, and the workflow uses the output value.

Copilot · 2025-11-19T13:11:07Z

.github/actions/E2ECalculateTestParams/E2ECalculateTestParams.ps1

+elseif ($matrixType) {
+    # For upgrade tests or other scenarios
+    if ($matrixType -eq 'appSourceApp') {
+        $template = "$githubOwner/$appSourceAppRepo"
+    }
+    else {
+        $template = "$githubOwner/$perTenantExtensionRepo"
+    }
+}


Lines 36-44 are unreachable dead code. If $matrixType is 'appSourceApp' or 'PTE', it's already handled by lines 30-35. The elseif block on line 36 will never execute. Remove lines 36-44.

Suggested change

elseif ($matrixType) {

# For upgrade tests or other scenarios

if ($matrixType -eq 'appSourceApp') {

$template = "$githubOwner/$appSourceAppRepo"

}

else {

$template = "$githubOwner/$perTenantExtensionRepo"

}

}

@copilot please do something about it

Already fixed in commit 32499d0. The dead code (lines 36-44) has been removed and replaced with proper contentPath calculation logic.

Co-authored-by: mazhelez <[email protected]>

Initial plan

530663c

Copilot AI assigned Copilot and mazhelez Nov 18, 2025

Copilot started work on behalf of mazhelez November 18, 2025 14:07 View session

Copilot AI and others added 2 commits November 18, 2025 14:18

Extract PowerShell code from E2E.yaml into local actions

8a356a1

Co-authored-by: mazhelez <[email protected]>

Add README documentation for new E2E actions

e97149e

Co-authored-by: mazhelez <[email protected]>

Copilot AI changed the title ~~[WIP] Extract PowerShell code from E2E.yaml~~ Extract PowerShell code from E2E.yaml into local actions Nov 18, 2025

Copilot AI requested a review from mazhelez November 18, 2025 14:30

Copilot finished work on behalf of mazhelez November 18, 2025 14:30

mazhelez reviewed Nov 19, 2025

View reviewed changes

.github/workflows/E2E.yaml Outdated Show resolved Hide resolved

Copilot started work on behalf of mazhelez November 19, 2025 07:20 View session

mazhelez reviewed Nov 19, 2025

View reviewed changes

Actions/E2ECheckSecrets/action.yaml Outdated Show resolved Hide resolved

Move E2E actions from Actions/ to .github/actions/

0d2f404

Co-authored-by: mazhelez <[email protected]>

Copilot AI requested a review from mazhelez November 19, 2025 07:26

Copilot finished work on behalf of mazhelez November 19, 2025 07:26

Copilot started work on behalf of mazhelez November 19, 2025 09:26 View session

Remove Invoke-AlGoAction.ps1 wrapper and call scripts directly

7cbba2e

Co-authored-by: mazhelez <[email protected]>

Copilot finished work on behalf of mazhelez November 19, 2025 09:32

github-advanced-security bot found potential problems Nov 19, 2025

View reviewed changes

Copilot started work on behalf of mazhelez November 19, 2025 11:38 View session

Fix code scanning and pre-commit issues in E2E actions

e6a2b0d

Co-authored-by: mazhelez <[email protected]>

Copilot finished work on behalf of mazhelez November 19, 2025 11:46

mazhelez marked this pull request as ready for review November 19, 2025 13:05

mazhelez requested a review from a team as a code owner November 19, 2025 13:05

Copilot AI review requested due to automatic review settings November 19, 2025 13:05

Copilot started reviewing on behalf of mazhelez November 19, 2025 13:07 View session

Copilot finished reviewing on behalf of mazhelez November 19, 2025 13:07

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Copilot started work on behalf of mazhelez November 19, 2025 14:57 View session

Remove invalid shell inputs and fix duplicate contentPath logic

32499d0

Co-authored-by: mazhelez <[email protected]>

Copilot finished work on behalf of mazhelez November 19, 2025 15:05

Copilot started work on behalf of mazhelez November 19, 2025 15:06 View session

Copilot finished work on behalf of mazhelez November 19, 2025 15:09

		contentPath: ${{ matrix.type == 'appSourceApp' && 'appsourceapp' \|\| 'pte' }}

Extract PowerShell code from E2E.yaml into local actions #2029

Are you sure you want to change the base?

Extract PowerShell code from E2E.yaml into local actions #2029

Conversation

Copilot AI commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❔What, Why & How

✅ Checklist

Uh oh!

Uh oh!

Uh oh!

Check warning

mazhelez Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Check warning

Check warning

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mazhelez commented Nov 19, 2025

Uh oh!

Copilot AI commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

mazhelez Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

mazhelez Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

mazhelez Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Nov 18, 2025 •

edited

Loading

Copilot AI commented Nov 19, 2025 •

edited

Loading