requests: ensure requests use local copy of headers dict.#964
Closed
agadsby wants to merge 2 commits intomicropython:masterfrom
agadsby:patch-1
Closed
requests: ensure requests use local copy of headers dict.#964agadsby wants to merge 2 commits intomicropython:masterfrom agadsby:patch-1
agadsby wants to merge 2 commits intomicropython:masterfrom
agadsby:patch-1
Conversation
Need to take a local copy of any headers passed in to requests() otherwise the caller's list gets incorrectly extended or modified. Signed-off-by: Andrew Gadsby <andrew@gadsby.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently requests() only creates a local copy of headers() if no headers dict is passed in. This means that any headers dict passed in will have extra entries added incorrectly. The code snip below illustrates the problem:
This fix uses a copy of the called headers to process the actual request.