aiohttp_ws: convert Sec-WebSocket-Key from bytes to str #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is the same as #846 |
Author
|
yes. Let's hope it will be merged soon ...
…On Wed, Apr 17, 2024 at 7:44 AM Carglglz ***@***.***> wrote:
I think this is the same as #846
<#846>
—
Reply to this email directly, view it on GitHub
<#849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATHYSZMERCZLTVS4KKGPBCDY52DFHAVCNFSM6AAAAABGLOURRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRRGQZTEMRSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Thanks for the patch, but I'll close this in favour of #846. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the fix, the client submits a header formatted as bytes:
resulting in the server rejecting the connection (I use the python websocket module in the server for checking). This PR decodes the key, and thus correctly formats the header: