Skip to content

Conversation

@shakuzen
Copy link
Member

Setting null has been allowed (although not tested or documented) since before we added nullability. This marks the API nullability accordingly.

TODO: We should add tests and documentation for this.

@shakuzen shakuzen linked an issue Jul 16, 2025 that may be closed by this pull request
@jonatan-ivanov jonatan-ivanov added this to the 1.6.x milestone Aug 11, 2025
Setting null has been allowed (although not tested or documented) since before we added nullability. This marks the API nullability accordingly.
@shakuzen shakuzen marked this pull request as ready for review October 14, 2025 08:21
@shakuzen shakuzen modified the milestones: 1.6.x, 1.6.0-RC1 Oct 14, 2025
@shakuzen shakuzen added the type: task A general task label Oct 14, 2025
@shakuzen
Copy link
Member Author

I'm merging this to get the nullability changes into RC1. There's still more work we need to do on this before GA. We don't document calling set/makeCurrent with null to remove the baggage. I believe this is supported with Brave, but for OTel we need to update the implementation.

@shakuzen shakuzen merged commit 145eeca into micrometer-metrics:main Oct 14, 2025
8 checks passed
@shakuzen shakuzen deleted the null-bags branch October 14, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing @Nullable in bridge for brave Baggage implementation

2 participants