Added support of @MeterTag annotation on method level #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marina Moiseenko <[email protected]>
MarinaMoiseenko
force-pushed
the
create-tags-based-on-method-result-2
branch
from
8a4cc08 to
0caa68f
Compare
shakuzen
approved these changes
Jan 28, 2025
| throw e; | ||
| } | ||
| } | ||
|
|
||
| private void recordCompletionResult(ProceedingJoinPoint pjp, Counted counted, Throwable throwable) { | ||
| private void recordCompletionResult(ProceedingJoinPoint pjp, Object methodResult, Counted counted, |
There was a problem hiding this comment.
We should mark the methodResult as @Nullable.
| void meterTagsOnReturnValueWithText(AnnotatedTestClass annotatedClass) { | ||
| MeterTagClassInterface service = getProxyWithCountedAspect(annotatedClass.newInstance()); | ||
|
|
||
| service.getAnnotationForArgumentToString(); |
There was a problem hiding this comment.
The method name doesn't match what's being tested - it's confusing (at least to me). Perhaps something like getAnnotationForReturnValueToString would be more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
re-created pr with new branch, as failed to rebase initial one