Add a test verifying that a single character meter name is allowed for Prometheus #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
approved these changes
Jan 6, 2025
I think it'll be best for us to leave it up to users to override the version of the Prometheus client to the one they want if they are affected by this particular issue and can't upgrade from Micrometer 1.13.x. |
jonatan-ivanov
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test verifying that a single character meter name is allowed for Prometheus.
There seems to have been a regression that prometheus/client_java#951 has fixed in 1.3.0 or later, and Micrometer 1.13.x uses Prometheus Java client 1.2.1 that doesn't contain the fix, so the test that this PR adds fails.
I'm not sure if it's worth upgrading to Prometheus Java client 1.3.0 or later to fix it as it's a minor upgrade that might cause other compatibility issues.
The migration guide for Micrometer 1.13 contains an entry for it, and it sounds like a feature, so at least we might want to update the guide to rephrase it.