Include minimumExpectedValue in exponential histogram #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thanks for the pull request. I was trying to think of another way we can do this. If it's just about where to record a value (positive buckets or zero count), we can just keep track of the minimumExpectedValue and change the conditional to be < rather than <=. But since we need to include the zero_threshold in the snapshot, this may be the best way to do it.
lenin-jaganathan
deleted the
inclusive_minexpected_exponential_histogram
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5393