Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to Spring Boot 2.7.18 #4409

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 29, 2023

This PR updates samples to Spring Boot 2.7.18.

@izeye
Copy link
Contributor Author

izeye commented Nov 29, 2023

Dependabot handles Gradle Enterprise Gradle plugin but doesn't seem to handle other Gradle plugins like this and #4410.

@shakuzen
Copy link
Member

Unfortunately dependabot's support of the Java ecosystem and Gradle is limited in multiple ways. This might be another such limitation. It may work if we migrate the plugin declaration to reference something in the toml version catalog.

@shakuzen
Copy link
Member

That said, in regards to the spring samples, I think we should rather work to remove them from the micrometer repo and make sure anything we want covered is included in the micrometer-samples or other repo. Having them in the micrometer repo makes a circular dependency, which isn't the end of the world for a sample, but it's also unnecessary if we can do the same thing in a samples repo.

@jonatan-ivanov jonatan-ivanov added the dependency-upgrade A dependency upgrade label Dec 15, 2023
@jonatan-ivanov jonatan-ivanov added this to the 1.9.18 milestone Dec 15, 2023
@jonatan-ivanov
Copy link
Member

Let me merge this so that we are using the latest version and then we can move them to the samples repo.

@jonatan-ivanov
Copy link
Member

Thank you!

@jonatan-ivanov jonatan-ivanov merged commit 7cadefd into micrometer-metrics:1.9.x Dec 15, 2023
@izeye izeye deleted the spring-boot-2.7.18 branch December 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants