Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the highestToLowestValueRatio according to the config #1808

Open
wants to merge 1 commit into
base: 1.1.x
Choose a base branch
from

Conversation

shelliglick
Copy link

@shelliglick shelliglick commented Jan 19, 2020

to solve issue described here #1807

@jkschneider
Copy link
Contributor

jkschneider commented Mar 18, 2020

Thank you @shelliglick! It does fail for certain values it seems.

@jkschneider jkschneider changed the base branch from 1.0.x to 1.2.x March 18, 2020 14:28
@jkschneider
Copy link
Contributor

Moving to baseline 1.2.x since the 1.0.x line is now EOL with the release of 1.0.11.

@jkschneider
Copy link
Contributor

Oops, should have moved to 1.1.x line instead.

@jkschneider jkschneider changed the base branch from 1.2.x to 1.1.x March 18, 2020 14:37
@jkschneider jkschneider added this to the 1.1.12 milestone Mar 18, 2020
@shakuzen shakuzen removed this from the 1.1.12 milestone Mar 30, 2020
@drstevens
Copy link

Any update on this? I noticed that 1.1.12 is closed.

@pivotal-issuemaster
Copy link

@shelliglick Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants