Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Histogram should include minimumExpectedValue in positive buckets #5393

Closed
lenin-jaganathan opened this issue Aug 16, 2024 · 0 comments · Fixed by #5394
Closed
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone

Comments

@lenin-jaganathan
Copy link
Contributor

lenin-jaganathan commented Aug 16, 2024

minimumExpectedValue is supposed to be inclusive with respect to buckets included in the histogram, but these test assertions show it's being treated as exclusive with regards to what is included in the bucket counts. I fear we have a bit of a mismatch here trying to use minimumExpectedValue for zeroThreshold because OTLP expects zeroThreshold to be inclusive of what ends up in the zeroCount.

  // ZeroThreshold may be optionally set to convey the width of the zero
  // region. Where the zero region is defined as the closed interval
  // [-ZeroThreshold, ZeroThreshold].

Originally posted by @shakuzen in #3959 (comment)

Current Behaviour
Currently, zeroCount in the exponential histogram includes the minimum expected value. This in turn excludes the minimumExpectedValue from actual distribution.

Expected Behaviour
zeroCount should be exclusive of minimumExpectedValue

@shakuzen shakuzen added bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related labels Aug 21, 2024
@shakuzen shakuzen added this to the 1.14.0-M3 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants