Refactor config path handling to filepath - #269
Closed
mynk8 wants to merge 3 commits into
Closed
Conversation
Add helper to compute config path from home with fallback Switch to filepath for path joins and directory ops in local config code for correctly handling platform conventions Signed-off-by: mynk8 <mr.mayankgame@gmail.com>
lbroudoux
reviewed
May 4, 2026
lbroudoux
left a comment
lbroudoux
left a comment
Member
There was a problem hiding this comment.
Looks legit but I have one question thought on the getHomeDir() function provenance. Thanks!
| ) | ||
|
|
||
| func defaultConfigPath() string { | ||
| homeDir, err := getHomeDir() |
Member
There was a problem hiding this comment.
Sorry if it's a dumb question, but where does this getHomeDir() method come from?
Author
There was a problem hiding this comment.
Although I would agree it's a bit confusing to be there and had the thought of whether move this into utility functions.
Member
|
Hey @mynk8, can you again take look on this PR. Please resolve the merge conflict, and will be happy to merge it when it's ready. |
Author
|
Closing this PR, the problem it solved is now fixed in the main branch so this change is not needed anymore and outdated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using
filepathkeeps Unix behavior unchanged while producing native separators on Windows.MICROCKS_CONFIG_DIRremains respected.Related issue(s)
Fixes #268