WIP: Meson/Maven build for MMCoreJ #696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marktsuchida
force-pushed
the
meson-mmcorej
branch
from
3182bcd to
ff83d76
Compare
15 tasks
marktsuchida
force-pushed
the
meson-mmcorej
branch
from
a5be971 to
5ea8910
Compare
We'll leave that for Maven.
Put in more logical order. Also remove redundant packaging=jar (it's the default).
Could be scm:git:[email protected] or scm:git:https://github.com but not scm:git:git://github.com. At least not any more.
More concise name/description. Update/correct developer organizations.
This is needed for Maven to use them cleanly. Because SWIG fails if the outdir doesn't exist, use a Python wrapper to run SWIG.
- Point to SWIG-generated Java sources in builddir/ (hard-coded for now) - Remove obsolete Sonatype OSSRH config (will need to add Central Portal config later) - Update plugin versions
It's cleaner for the outer script to set builddir equally for Meson and Maven, so parameterize.
Until we have a proper way to address them, there're not helpful.
marktsuchida
force-pushed
the
meson-mmcorej
branch
from
5ea8910 to
3e97b57
Compare
Member
Author
|
Removed Java compile/jar from Meson build and updated pom.xml so that Maven can build using SWIG Java sources generated by Meson. This way we don't have to manually mess with the jar/pom during build. The jars produced (artifactId = MMCoreJ) are the Java part only. Next steps:
|
marktsuchida
changed the title
(Assisted by Claude Code; any errors are mine.)
There is not much point in pinning the mmdevice and mmcore commits until MMCoreJ is in its own repository and no longer in mmCoreAndDevices.
Without this, there is the danger of producing a jar with only the static sources. (Assisted by Claude Code; any errors are mine.)
(Assisted by Claude Code; any errors are mine.)
marktsuchida
force-pushed
the
meson-mmcorej
branch
from
9390b4f to
10df97d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
The goal to aim for is a stand-alone mmcorej repository (initially a mirror of
MMCoreJ_wrap/) that is analogous to pymmcore, which publishes to the Maven Central repository.Major things remaining to do:
meson dist)pom.xmlwith version frommeson.build(probably not while MMCoreJ lives in mmCoreAndDevices)pom.xmlin jarThe Javadoc generation requires some thought. We currently use the ancient swig-doc-converter, which I'd like to retire. SWIG 4 can translate Doxygen to Javadoc, but (a) we still require SWIG 2/3 for MMCoreJ (#37) and (b) the doc comments of MMCore will need to be in the headers for that to work (#23 - probably best to do when no major PRs are outstanding on MMCore). Might be best to tackle those issues first.Let's keep swig-doc-converter for now so we don't need to switch to SWIG 4 yet here.