Made docker-gen being run once just before logrotate, fixed logrotate…

… config and moved some stuff to env vars

Dockerfile

@@ -22,14 +22,21 @@ RUN curl -sL https://github.com/michaloo/go-cron/releases/download/v0.0.2/go-cro
 ADD . /app
 WORKDIR /app
 
-# clear logrotate ubuntu installation and enable debug information
+# clear logrotate ubuntu installation and modify logrotate script
+# add docker-gen execution and enable debug mode
 RUN rm /etc/logrotate.d/* && \
-    sed -i -e 's/^\/usr\/sbin\/logrotate.*/\/usr\/sbin\/logrotate \-v \/etc\/logrotate.conf/' /etc/cron.daily/logrotate
+    sed -i \
+    -e 's/^\/usr\/sbin\/logrotate.*/\/usr\/sbin\/logrotate \-v \/etc\/logrotate.conf/' \
+    -e '/\#\!\/bin\/sh/a /usr/local/bin/docker-gen /root/logrotate.tmpl /etc/logrotate.d/docker' \
+    /etc/cron.daily/logrotate
 
 # set default configuration
 ENV DOCKER_HOST unix:///var/run/docker.sock
 ENV DOCKER_DIR /var/lib/docker/
 ENV GOCRON_SCHEDULER 0 0 * * * *
+ENV LOGROTATE_MODE daily
+ENV LOGROTATE_ROTATE 3
+ENV LOGROTATE_SIZE 512M
 
 ENTRYPOINT [ "/bin/bash" ]
 CMD [ "/app/start" ]

crane.yml

@@ -21,3 +21,5 @@ containers:
         - "/var/run/docker.sock:/var/run/docker.sock"
         - "/var/lib/docker:/var/lib/docker"
       detach: true
+      env:
+        - "GOCRON_SCHEDULER=0 * * * * *"

logrotate.tmpl

@@ -1,14 +1,12 @@
 {{ range $index, $value := $ }}
-/var/lib/docker/containers/{{ $value.ID }}/{{ $value.ID }}-json.log
+/var/lib/docker/containers/{{ $value.ID }}/{{ $value.ID }}-json.log{{ end }}
 {
-    daily
+    {{LOGROTATE_MODE}}
     missingok
-    rotate 3
-    size 512M
+    rotate {{LOGROTATE_ROTATE}}
+    size {{LOGROTATE_SIZE}}
     compress
     notifempty
-    # create 644 root root
-    copy
     copytruncate
 }
-{{ end }}
+

start

@@ -1,14 +1,9 @@
 #!/bin/bash
 
-# using sed to strip color codes from forego output
-#exec /usr/local/bin/forego start | sed -r "s:\x1B\[[0-9;]*[mK]::g"
+sed -e 's/{{LOGROTATE_MODE}}/'"$LOGROTATE_MODE"'/' \
+    -e 's/{{LOGROTATE_ROTATE}}/'"$LOGROTATE_ROTATE"'/' \
+    -e 's/{{LOGROTATE_SIZE}}/'"$LOGROTATE_SIZE"'/' \
+    /app/logrotate.tmpl > /root/logrotate.tmpl
 
-set -m
+exec /usr/local/bin/go-cron "$GOCRON_SCHEDULER" /etc/cron.daily/logrotate
 
-trap 'kill $(jobs -p)' EXIT
-trap "exit" CHLD
-
-/usr/local/bin/docker-gen -watch /app/logrotate.tmpl /etc/logrotate.d/docker &
-/usr/local/bin/go-cron "$GOCRON_SCHEDULER" /etc/cron.daily/logrotate &
-
-wait