Unblock Node.js v12 with appropriate warning (Azure#255)

* Unblock Node.js v12 with appropriate warning

* add test

* adding e2e test too

* updating to 1.2.0

* Workaround to protobuf.js issue

Author: mhoeger

Worker.nuspec

@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
   <metadata>
     <id>Microsoft.Azure.Functions.NodeJsWorker</id>
-    <version>1.1.1$version$</version>
+    <version>1.2.0$version$</version>
     <authors>Microsoft</authors>
     <owners>Microsoft</owners>
     <requireLicenseAcceptance>false</requireLicenseAcceptance>

azure-pipelines.yml

@@ -1,7 +1,8 @@
 variables: {
-  WORKER_VERSION: '1.1.1',
-  NODE_LOWER_LTS: '8.x',
-  NODE_HIGHER_LTS: '10.x'
+  WORKER_VERSION: '1.2.0',
+  NODE_8: '8.x',
+  NODE_10: '10.x',
+  NODE_12: '12.x'
 }
 name: $(WORKER_VERSION)-$(Date:yyyyMMdd)$(Rev:.r)
 
@@ -15,22 +16,31 @@ jobs:
     matrix:
       UBUNTU_NODE8:
         IMAGE_TYPE: 'ubuntu-latest'
-        NODE_VERSION: $(NODE_LOWER_LTS)
+        NODE_VERSION: $(NODE_8)
       UBUNTU_NODE10:
         IMAGE_TYPE: 'ubuntu-latest'
-        NODE_VERSION: $(NODE_HIGHER_LTS)
+        NODE_VERSION: $(NODE_10)
+      UBUNTU_NODE12:
+        IMAGE_TYPE: 'ubuntu-latest'
+        NODE_VERSION: $(NODE_12)
       WINDOWS_NODE8:
         IMAGE_TYPE: 'vs2017-win2016'
-        NODE_VERSION: $(NODE_LOWER_LTS)
+        NODE_VERSION: $(NODE_8)
       WINDOWS_NODE10:
         IMAGE_TYPE: 'vs2017-win2016'
-        NODE_VERSION: $(NODE_HIGHER_LTS)
+        NODE_VERSION: $(NODE_10)
+      WINDOWS_NODE12:
+        IMAGE_TYPE: 'vs2017-win2016'
+        NODE_VERSION: $(NODE_12)
       MAC_NODE8:
         IMAGE_TYPE: 'macos-10.13'
-        NODE_VERSION: $(NODE_LOWER_LTS)
+        NODE_VERSION: $(NODE_8)
       MAC_NODE10:
         IMAGE_TYPE: 'macos-10.13'
-        NODE_VERSION: $(NODE_HIGHER_LTS)
+        NODE_VERSION: $(NODE_10)
+      MAC_NODE12:
+        IMAGE_TYPE: 'macos-10.13'
+        NODE_VERSION: $(NODE_12)
   pool:
     vmImage: $(IMAGE_TYPE)
   steps:
@@ -50,9 +60,11 @@ jobs:
     maxParallel: 1
     matrix:
       NODE8:
-        NODE_VERSION: $(NODE_LOWER_LTS)
+        NODE_VERSION: $(NODE_8)
       NODE10:
-        NODE_VERSION: $(NODE_HIGHER_LTS)
+        NODE_VERSION: $(NODE_10)
+      NODE12:
+        NODE_VERSION: $(NODE_12)
   pool:
     vmImage: 'vs2017-win2016'
   steps:
@@ -83,7 +95,7 @@ jobs:
   steps:
   - task: NodeTool@0
     inputs:
-      versionSpec: $(NODE_HIGHER_LTS)
+      versionSpec: $(NODE_10)
     displayName: 'Install Node.js for test'
   - powershell: .\package.ps1
   - task: NuGetCommand@2

e2e-nightly-cli-azure-pipelines.yml

@@ -1,5 +1,5 @@
 variables: {
-  WORKER_VERSION: '1.1.1',
+  WORKER_VERSION: '1.2.0',
   NODE_LOWER_LTS: '8.x',
   NODE_HIGHER_LTS: '10.x'
 }

e2e-nightly-site-azure-pipelines.yml

@@ -1,5 +1,5 @@
 variables: {
-  WORKER_VERSION: '1.1.1',
+  WORKER_VERSION: '1.2.0',
   NODE_LOWER_LTS: '8.x',
   NODE_HIGHER_LTS: '10.x'
 }

package.json

@@ -1,7 +1,7 @@
 {
   "name": "azure-functions-nodejs-worker",
   "author": "Microsoft Corporation",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "description": "Microsoft Azure Functions NodeJS Worker",
   "license": "(MIT OR Apache-2.0)",
   "dependencies": {

package.ps1

@@ -38,6 +38,13 @@ StopOnFailedExecution # fail if error
 ./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=10.1.0 --target_platform=win32
 ./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=10.1.0 --target_platform=darwin
 ./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=10.1.0 --target_platform=linux --target_libc=glibc
+# Node 12 support
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=ia32 --target=12.13.0 --target_platform=win32
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=ia32 --target=12.13.0 --target_platform=darwin
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=ia32 --target=12.13.0 --target_platform=linux --target_libc=glibc
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=12.13.0 --target_platform=win32
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=12.13.0 --target_platform=darwin
+./node_modules/.bin/node-pre-gyp install -C pkg/grpc --target_arch=x64 --target=12.13.0 --target_platform=linux --target_libc=glibc
 copy-item Worker.nuspec pkg/
 
 if ($NugetPack)

scripts/generateProtos.js

@@ -20,10 +20,13 @@ async function generateProtos() {
     genJs(allFiles)
         .then(data => console.log("Compiled to JavaScript."))
         .catch(err => console.log(`Could not compile to JavaScript: ${err}`));
-
-    genTs(allFiles)
+    
+    // Don't generate with Node.js v12 until resolved: https://github.com/protobufjs/protobuf.js/issues/1275
+    if (!process.version.startsWith("v12")) {
+        genTs(allFiles)
         .then(data => console.log("Compiled to TypeScript."))
         .catch(err => console.log(`Could not compile to TypeScript: ${err}`));
+    }
 };
 
 async function getFiles(root, fileFilter, directoryFilter) {

src/nodejsWorker.ts

@@ -1,6 +1,7 @@
 var logPrefix = "LanguageWorkerConsoleLog";
 var errorPrefix = logPrefix + "[error] ";
-var supportedVersions:string[] = ["v8","v10"];
+var warnPrefix = logPrefix + "[warn] ";
+var supportedVersions:string[] = ["v8","v10", "v12"];
 var worker;
 
 // Try validating node version
@@ -21,6 +22,12 @@ function validateNodeVersion(version) {
                 ", but the runtime requires an LTS-covered major version. LTS-covered versions have an even major version number (8.x, 10.x, etc.) as per https://github.com/nodejs/Release#release-plan. "
                 + "For deployed code, change WEBSITE_NODE_DEFAULT_VERSION to '~10' in App Settings. Locally, install or switch to a supported node version (make sure to quit and restart your code editor to pick up the changes).";
         }
+        // Log a warning that v12 is not fully supported
+        if (major === "v12")
+        {
+            console.warn(warnPrefix + "The Node.js version you are using (" + version + ") is not fully supported by Azure Functions V2. We recommend using one the following major versions: 8, 10.");
+        }
+        
     // Unknown error
     } catch(err) {
         var unknownError = "Error in validating Node.js version. ";

types/public/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/functions",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "description": "Azure Functions types for Typescript",
   "repository": {
     "type": "git",