Re-setting working directory if given (Azure#257)

* Re-setting working directory if given

* changing yaml

* address cr

Author: mhoeger

azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto

@@ -189,6 +189,8 @@ message WorkerStatusResponse {
 message FunctionEnvironmentReloadRequest {
   // Environment variables from the current process
   map<string, string> environment_variables = 1;
+  // Current directory of function app
+  string function_app_directory = 2;
 }
 
 message FunctionEnvironmentReloadResponse {

azure-pipelines.yml

@@ -75,17 +75,6 @@ jobs:
       AzureWebJobsCosmosDBConnectionString: $(AzureWebJobsCosmosDBConnectionString)
       FUNCTIONS_WORKER_RUNTIME: 'node'
       languageWorkers:node:workerDirectory: $(System.DefaultWorkingDirectory)
-  - task: CopyFiles@2
-    inputs:
-     SourceFolder: '$(System.DefaultWorkingDirectory)/test/testResults'
-     Contents: '*.trx'
-     TargetFolder: '$(Build.ArtifactStagingDirectory)'
-  - task: PublishBuildArtifacts@1
-    inputs:
-     PathtoPublish: '$(Build.ArtifactStagingDirectory)'
-     ArtifactName: 'testResults'
-     publishLocation: 'Container'
-  displayName: 'Run tests and publish test result artifacts'
   
 - job: BuildArtifacts  
   condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/master'))

src/WorkerChannel.ts

@@ -257,6 +257,16 @@ export class WorkerChannel implements IWorkerChannel {
     let error = null;
     try {
       process.env = Object.assign({}, msg.environmentVariables);
+      // Change current working directory
+      if (msg.functionAppDirectory)
+      {
+        this.log({
+          message: `Changing current working directory to ${msg.functionAppDirectory}`,
+          level: LogLevel.Information,
+          logCategory: LogCategory.System
+        });
+        process.chdir(msg.functionAppDirectory);
+      }
     } catch (e)
     {
       error = e;

test/WorkerChannelTests.ts

@@ -93,7 +93,8 @@ describe('WorkerChannel', () => {
         environmentVariables: {
           "hello": "world",
           "SystemDrive": "Q:"
-        }
+        },
+        functionAppDirectory: null
       }
     });
     sinon.assert.calledWith(stream.written, <rpc.IStreamingMessage>{
@@ -115,7 +116,8 @@ describe('WorkerChannel', () => {
     stream.addTestMessage({
       requestId: 'id',
       functionEnvironmentReloadRequest: {  
-        environmentVariables: {}
+        environmentVariables: {},
+        functionAppDirectory: null
       }
     });
     sinon.assert.calledWith(stream.written, <rpc.IStreamingMessage>{
@@ -134,7 +136,8 @@ describe('WorkerChannel', () => {
       stream.write({
         requestId: 'id',
         functionEnvironmentReloadRequest: {  
-          environmentVariables: {}
+          environmentVariables: {},
+          functionAppDirectory: null
         }
       });
     }).to.not.throw();
@@ -150,12 +153,66 @@ describe('WorkerChannel', () => {
       stream.write({
         requestId: 'id',
         functionEnvironmentReloadRequest: {
-          environmentVariables: null
+          environmentVariables: null,
+          functionAppDirectory: null
         }
       });
     }).to.not.throw();
   });
 
+  it ('reloads environment variable and keeps cwd without functionAppDirectory', () => {
+    let cwd = process.cwd();
+    stream.addTestMessage({
+      requestId: 'id',
+      functionEnvironmentReloadRequest: {  
+        environmentVariables: {
+          "hello": "world",
+          "SystemDrive": "Q:"
+        },
+        functionAppDirectory: null
+      }
+    });
+    sinon.assert.calledWith(stream.written, <rpc.IStreamingMessage>{
+      requestId: 'id',
+      functionEnvironmentReloadResponse: {
+        result: {
+          status: rpc.StatusResult.Status.Success
+        }
+      }
+    });
+    expect(process.env.hello).to.equal("world");
+    expect(process.env.SystemDrive).to.equal("Q:");
+    expect(process.cwd() == cwd);
+  });
+
+  it ('reloads environment variable and changes functionAppDirectory', () => {
+    let cwd = process.cwd();
+    let newDir = "/";
+    stream.addTestMessage({
+      requestId: 'id',
+      functionEnvironmentReloadRequest: {  
+        environmentVariables: {
+          "hello": "world",
+          "SystemDrive": "Q:"
+        },
+        functionAppDirectory: newDir
+      }
+    });
+    sinon.assert.calledWith(stream.written, <rpc.IStreamingMessage>{
+      requestId: 'id',
+      functionEnvironmentReloadResponse: {
+        result: {
+          status: rpc.StatusResult.Status.Success
+        }
+      }
+    });
+    expect(process.env.hello).to.equal("world");
+    expect(process.env.SystemDrive).to.equal("Q:");
+    expect(process.cwd() != newDir);
+    expect(process.cwd() == newDir);
+    process.chdir(cwd);
+  });
+
   it ('invokes function', () => {
     loader.getFunc.returns((context) => context.done());
     loader.getInfo.returns({