Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #280

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Fix typos #280

merged 1 commit into from
Jan 11, 2025

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 10, 2025

This PR fixes various typos I spotted in the project.

@mgieseki
Copy link
Owner

Thank you for taking the time to fix these and for creating the PR. I'll gladly merge it but could you please remove your changes from the files below the libs and tests/gtest folders? These belong to 3rd-party libraries bundled with dvisvgm and I'd like to keep their original sources.

@mgieseki mgieseki self-assigned this Jan 10, 2025
@deining
Copy link
Contributor Author

deining commented Jan 10, 2025

Thank you for taking the time to fix these and for creating the PR.

You are welcome.

I'll gladly merge it but could you please remove your changes from the files below the libs and tests/gtest folders? These belong to 3rd-party libraries bundled with dvisvgm and I'd like to keep their original sources.

Done.

@mgieseki mgieseki merged commit 17cba7c into mgieseki:master Jan 11, 2025
1 check passed
@mgieseki
Copy link
Owner

Great, thanks again.

@deining deining deleted the fix-typos branch January 11, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants