prevent already escaped double quotes from being escaped again, causi…

…ng a syntax error
mghoneimy · Mar 21, 2024 · 5b16741 · 5b16741
1 parent caadeba
commit 5b16741
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Util/StringLiteralFormatter.php b/src/Util/StringLiteralFormatter.php
@@ -20,7 +20,7 @@ public static function formatValueForRHS($value): string
     {
         if (is_string($value)) {
             if (!static::isVariable($value)) {
-                $value = str_replace('"', '\"', $value);
+                $value = preg_replace(['/([^\\\])"/', '/^"/'], ['$1\"', '\"'], $value);
                 if (strpos($value, "\n") !== false) {
                     $value = '"""' . $value . '"""';
                 } else {

diff --git a/tests/StringLiteralFormatterTest.php b/tests/StringLiteralFormatterTest.php
@@ -34,6 +34,9 @@ public function testFormatForClassRHSValue()
         $formattedString = StringLiteralFormatter::formatValueForRHS("\"quotedString\"");
         $this->assertEquals('"\"quotedString\""', $formattedString);
 
+        $formattedString = StringLiteralFormatter::formatValueForRHS('<span class=\\"quotedStringEscaped\\" id="unescaped"></span>');
+        $this->assertEquals('"<span class=\\"quotedStringEscaped\\" id=\\"unescaped\\"></span>"', $formattedString);
+
         $formattedString = StringLiteralFormatter::formatValueForRHS('\'singleQuotes\'');
         $this->assertEquals('"\'singleQuotes\'"', $formattedString);