-
Notifications
You must be signed in to change notification settings - Fork 10
Fix for OSX network interface. set to en0 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This won't work for one of my Macs that is currently hooked up to ethernet via a USB-C docking station. It's using en10. route get default | grep interface | awk '{print $2}' I'd rather see the interface optional passed in via a parameter, e.g. something like: node Device.js -interface $(route get default | grep interface | awk '{print $2}') If "-interface" not used, it would act as it does now |
I also think that this is way to specific. The network interfaces are very dynamic and deopend on many factors. en0 csn be anything. So @vves what exactly you have as error? I also curremtly look into that aside and gathered some ideas today #11 (comment) |
I mentioned the same in #11, but will repeat here, there should be an optional command line argument to specify interface and perhaps even the IP. If the standard specifies IPV6 only, perhaps support for IPV4 can be dropped |
Yes I will also consider this in my coming PR |
Note the Multicast Server error below. I have three OSX boxes across two users of this library that this is a very minor change so that the library works out of the box. I agree that better command line reference would be useful, but I would think most consumers of this library including my team will be implementing their own 'Device' or 'Bridge' so I take Device.ts as a template more than a final implementation. Is it worth adding more command line params or just make the demo run out-of-the-box as the case may be. Additionally - 'en0' is always defined on OSX as ethernet if it exists and wireless if a wired connection is not available. This method provides a narrow fix for OSX users without changing the behavior for other platforms. QR Code URL: https://project-chip.github.io/connectedhomeip/qrcode.html?data=MT:Y.K90AFN00KA0648G00 |
It's not an OSX only issue. I am seeing many interfaces on linux VMs as well as RPIs where I am testing node-matter.
…Sent from my mobile device
________________________________
From: Wes ***@***.***>
Sent: Wednesday, February 15, 2023 6:52:52 PM
To: mfucci/node-matter ***@***.***>
Cc: Jatin Desai ***@***.***>; Comment ***@***.***>
Subject: Re: [mfucci/node-matter] Fix for OSX network interface. set to en0 (PR #254)
Note the Multicast Server error below I have three OSX boxes across two users of this library that this is 'enough' so that the library works out of the box. I agree that better command line reference would be useful, but I would think most consumers of this library including my team will be implementing their own 'Device' or 'Bridge' so I take Device.ts as a template more than a final implementation. Is it worth adding more command line params or just make the demo run out-of-the-box as the case may be. 'en0' is always defined on OSX as ethernet if it exists and wireless if a wired connection is not available. This method provides a narrow fix for OSX users without changing the behavior for other platforms.
QR Code URL: https://project-chip.github.io/connectedhomeip/qrcode.html?data=MT:Y.K90AFN00KA0648G00<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fproject-chip.github.io%2Fconnectedhomeip%2Fqrcode.html%3Fdata%3DMT%3AY.K90AFN00KA0648G00&data=05%7C01%7C%7C037d6e5dbd1744e3739b08db0fafc12d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638121019756644697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NeiaYLgZ2wKTCEaAd67tH2niBK4jrKktgCOxiLCGdxk%3D&reserved=0>
Manual pairing code: 34970112332
2023-02-15 16:47:19.094 INFO UdpMulticastServer utun2: send EMSGSIZE ff02::fb:5353
—
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmfucci%2Fnode-matter%2Fpull%2F254%23issuecomment-1432244281&data=05%7C01%7C%7C037d6e5dbd1744e3739b08db0fafc12d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638121019756644697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3W69V1RR%2FFSPwH8PllUERPJOfUFQ8md2WDBzIukFLR4%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADBZQWFEAYTGAO7W7ISGC4LWXVT5JANCNFSM6AAAAAAU5LCETA&data=05%7C01%7C%7C037d6e5dbd1744e3739b08db0fafc12d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638121019756644697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6SPVfg8ThwdX1CJ3c7RYUYRXwcV2b8sYc209c1GlFcY%3D&reserved=0>.
You are receiving this because you commented.Message ID: ***@***.***>
|
@jdesai61 - thanks for the updated information. I have a three different linux flavor VMs but had only tested on one and it was fine. I'll double check with the other two. I still question if the Device.js is just a template for node-matter consumers to use as a template how far down the rabbit hole of fixing this we should go. BRB with results from my other VMs. |
I would more tend to solve it "correctly" ... |
I'll probably leave it open for someone else to work on then - I am going to start on the Window Covering cluster as that's what I am missing to make the library useful for my use case. |
Note. Both my Debian 11.3 and Ubuntu 22.04 VM instances provide IPv4 address before the IPv6 in the ips array and iOS Home App does not find the Matter Virtual Device and start the commissioning process. Curiously - the MdnsBroadcaster changes IP addresses on Debian Linux after ~10 seconds to - On OSX, the IPv6 address is listed first in the array and Home App is able to pair: Not sure if this has anything to do with the Home App not being able to locate the Virtual Device on the network or if it's a red-herring. Just more information. |
@jdesai61 I was able to confirm that using a Belkin hub that en4 becomes this interface on OSX.. I am removing pull request for now. |
I will have a PR soon but after playing around two days with that topic I just add to allow to select the interface to send out the annoucemements ... In fact all "receiving" parts need to listen to anything and in fact the UDP traffic can come in on any interface in the end. As soon as you limit this you end is issues over and over |
No description provided.