Optimize Fabric deletion and destroy sessions #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfucci
requested changes
Feb 13, 2023
| @@ -119,7 +119,13 @@ export const OperationalCredentialsClusterHandler: (conf: OperationalCredentials | |||
|
|
|||
There was a problem hiding this comment.
Removing session associated with a fabric when a fabric is deleted should be done by the FabricManager, otherwise there is too much risk to have the system in an incoherent state.
There was a problem hiding this comment.
I moved it to "MatterDevcie" now because FabricManager do not have acces to the session controller but the device is taling care here too ... so should work?
ALternatively Ineed to pass the sessionmanager with removeFabric justto call from there ...
|
@mfucci COmments addressed ... one topic basically open - see above, but I did a change to where it also could make sense in my eyes. Ready for re-review |
mfucci
reviewed
Feb 26, 2023
|
@mfucci Adjusted as discussed |
mfucci
requested changes
Mar 7, 2023
mfucci
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Fabric gets deleted the current session associated with the Fabric needs to be destroyed. If it is the last fabric all other remaining sessions also needs to be destroyed