Handle empty Subscription DataReports correctly #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfucci
requested changes
Feb 13, 2023
mfucci
requested changes
Feb 19, 2023
|
@mfucci Adjusted as talked |
mfucci
reviewed
Feb 26, 2023
|
Ready for re-review |
mfucci
requested changes
Mar 11, 2023
|
Ready for re-review |
mfucci
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the correct handling for "empty" Datareports as result for subscriptions, because according to specs they should set suppressResponse to true. So we also give this info to the messenger to allow a rejection if the other party answers with some ther message (e.g. a "invalid subscription id" message that we need to use to cancel the subscription.