Really check for Statuscode errors and return Error classes #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfucci
requested changes
Feb 13, 2023
|
Ok, I checked more in deoth the throwIfError and waitForSuccess and optimized more ... hopefully now less "duplicate" code |
|
@mfucci Ready for re-reveiw ... I adjusted ... you were right regarding duplicste throwIfError |
mfucci
reviewed
Feb 26, 2023
|
Ready for re-review |
mfucci
requested changes
Mar 11, 2023
mfucci
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new Error classes to instoduce StatusError classes that are thrown when an unexpected StatusCode is returned.
This also fixes the "waitForSucces" to really wait for a success reswponse and not for "any" response