Skip to content

Update ID / name to match the certificate #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2023
Merged

Update ID / name to match the certificate #157

merged 1 commit into from
Jan 2, 2023

Conversation

mfucci
Copy link
Owner

@mfucci mfucci commented Dec 31, 2022

No description provided.

@mfucci mfucci requested a review from Apollon77 December 31, 2022 16:37
Apollon77
Apollon77 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Collaborator

@Apollon77 Apollon77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm ... so we also need to generate the certificate based on settings like name and vendor ids and such?

@mfucci
Copy link
Owner Author

mfucci commented Jan 2, 2023

Yes, ideally all the certificates should be auto-generated...
But at least IDs should match with what is declared.

@mfucci mfucci merged commit 2c71ad7 into main Jan 2, 2023
@mfucci mfucci deleted the fix-device-id branch January 2, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollon77 Apollon77 Apollon77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfucci @Apollon77