Fix crash in get_member_id() if client group is not initialized #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

azat wants to merge 1 commit into mfontanini:master from azat-archive:get_member_id-crash-upstream

Contributor

azat commented May 25, 2025

Since in this case rd_kafka_memberid() return NULL, and std::string cannot be constructed from NULL 1.

Refs: ClickHouse/ClickHouse#80674 (comment)


          Fix crash in get_member_id() if client group is not initialized

6343c43

Since in this case rd_kafka_memberid() return NULL, and std::string
cannot be constructed from NULL [1].

  [1]: https://github.com/llvm/llvm-project/blob/fe51d8ae5772626ef8237c33e0911695cf4f07db/libcxx/include/string#L1051-L1055

azat mentioned this pull request

Fix crash in get_member_id() if client group is not initialized ClickHouse/cppkafka#4

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet