Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use PHP 8.1 syntax #40

Merged
merged 1 commit into from
Nov 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/TwigEnvironmentFactory.php
Original file line number Diff line number Diff line change
@@ -140,8 +140,8 @@ public function __invoke(ContainerInterface $container): Environment
// Add template paths
$allPaths = isset($config['paths']) && is_array($config['paths']) ? $config['paths'] : [];
foreach ($allPaths as $namespace => $paths) {
$namespace = is_numeric($namespace) ? null : $namespace;
$namespace = $namespace ?? FilesystemLoader::MAIN_NAMESPACE;
$namespace = is_numeric($namespace) ? null : $namespace;
$namespace ??= FilesystemLoader::MAIN_NAMESPACE;
foreach ((array) $paths as $path) {
$loader->addPath($path, $namespace);
}
10 changes: 5 additions & 5 deletions src/TwigExtension.php
Original file line number Diff line number Diff line change
@@ -16,11 +16,11 @@
class TwigExtension extends AbstractExtension implements GlobalsInterface
{
public function __construct(
private ServerUrlHelper $serverUrlHelper,
private UrlHelper $urlHelper,
private ?string $assetsUrl,
private null|string|int $assetsVersion,
private array $globals = []
private readonly ServerUrlHelper $serverUrlHelper,
private readonly UrlHelper $urlHelper,
private readonly ?string $assetsUrl,
private readonly null|string|int $assetsVersion,
private readonly array $globals = []
) {
}

2 changes: 1 addition & 1 deletion src/TwigRenderer.php
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ public function render(string $name, $params = []): string
*/
public function addPath(string $path, ?string $namespace = null): void
{
$namespace = $namespace ?? FilesystemLoader::MAIN_NAMESPACE;
$namespace ??= FilesystemLoader::MAIN_NAMESPACE;
$this->twigLoader->addPath($path, $namespace);
}

2 changes: 1 addition & 1 deletion test/TwigExtensionTest.php
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ public function createExtension(?string $assetsUrl, $assetsVersion): TwigExtensi

public function assertFunctionExists(string $name, array $functions, ?string $message = null): void
{
$message = $message ?? sprintf('Failed to identify function by name %s', $name);
$message ??= sprintf('Failed to identify function by name %s', $name);
$function = $this->findFunction($name, $functions);
$this->assertInstanceOf(TwigFunction::class, $function, $message);
}
6 changes: 3 additions & 3 deletions test/TwigRendererFactoryTest.php
Original file line number Diff line number Diff line change
@@ -177,7 +177,7 @@ public function getConfigurationPaths(): array

public function assertPathsHasNamespace(?string $namespace, array $paths, ?string $message = null): void
{
$message = $message ?? sprintf('Paths do not contain namespace %s', $namespace ?? 'null');
$message ??= sprintf('Paths do not contain namespace %s', $namespace ?? 'null');

$found = false;
foreach ($paths as $path) {
@@ -196,7 +196,7 @@ public function assertPathNamespaceCount(
array $paths,
?string $message = null
): void {
$message = $message ?? sprintf('Did not find %d paths with namespace %s', $expected, $namespace ?? 'null');
$message ??= sprintf('Did not find %d paths with namespace %s', $expected, $namespace ?? 'null');

$count = 0;
foreach ($paths as $path) {
@@ -214,7 +214,7 @@ public function assertPathNamespaceContains(
array $paths,
?string $message = null
): void {
$message = $message ?? sprintf('Did not find path %s in namespace %s', $expected, $namespace ?? 'null');
$message ??= sprintf('Did not find path %s in namespace %s', $expected, $namespace ?? 'null');

$found = [];
foreach ($paths as $path) {
10 changes: 5 additions & 5 deletions test/TwigRendererTest.php
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ public function assertEqualTemplatePath(
TemplatePath $received,
?string $message = null
): void {
$message = $message ?? 'Failed to assert TemplatePaths are equal';
$message ??= 'Failed to assert TemplatePaths are equal';
if (
$expected->getPath() !== $received->getPath()
|| $expected->getNamespace() !== $received->getNamespace()
@@ -70,19 +70,19 @@ public function testCanAddPathWithEmptyNamespace(): void

public function assertTemplatePath(string $path, TemplatePath $templatePath, ?string $message = null): void
{
$message = $message ?? sprintf('Failed to assert TemplatePath contained path %s', $path);
$message ??= sprintf('Failed to assert TemplatePath contained path %s', $path);
$this->assertEquals($path, $templatePath->getPath(), $message);
}

public function assertTemplatePathString(string $path, TemplatePath $templatePath, ?string $message = null): void
{
$message = $message ?? sprintf('Failed to assert TemplatePath casts to string path %s', $path);
$message ??= sprintf('Failed to assert TemplatePath casts to string path %s', $path);
$this->assertEquals($path, (string) $templatePath, $message);
}

public function assertEmptyTemplatePathNamespace(TemplatePath $templatePath, ?string $message = null): void
{
$message = $message ?? 'Failed to assert TemplatePath namespace was empty';
$message ??= 'Failed to assert TemplatePath namespace was empty';
$this->assertEmpty($templatePath->getNamespace(), $message);
}

@@ -103,7 +103,7 @@ public function assertTemplatePathNamespace(
TemplatePath $templatePath,
?string $message = null
): void {
$message = $message ?? sprintf(
$message ??= sprintf(
'Failed to assert TemplatePath namespace matched %s',
var_export($namespace, true)
);