Deprecated SessionIdentifierAwareInterface for removal in v2.0
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexmerlin <[email protected]>
|
Hey @gsteel, thanks for jumping on this one. Could you please explain why the |
|
@alexmerlin check bottom of logs: you removed it from |
Signed-off-by: alexmerlin <[email protected]>
Signed-off-by: alexmerlin <[email protected]>
|
Hey @alexmerlin - You can't add methods to an interface without it being considered a BC break, because you are forcing implementors to add the method to their implementation. The patch to 1.x should only include the deprecation notice. All the changes need to go into the 2.0.x branch which doesn't exist yet. I'll create the 2.0.x branch now so you can open a different PR to make the changes 👍 |
|
Actually, hang fire on the 2nd patch - let's get 1.15.0 released first… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As requested in #59 this commit deprecates
SessionIdentifierAwareInterfaceand moves itsgetIdmethod toSessionInterface.